Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

update some python APIs #4099

Merged
6 commits merged into from
Jul 28, 2016
Merged

update some python APIs #4099

6 commits merged into from
Jul 28, 2016

Conversation

chadwhitacre
Copy link
Contributor

@chadwhitacre chadwhitacre commented Jul 22, 2016

#3994

#4094 (diff) — #4077

This fixes a few bugs and warts with Python APIs that we want to use in bringing back the takes UI.

This was referenced Jul 22, 2016
@chadwhitacre chadwhitacre force-pushed the update-some-python-APIs branch 2 times, most recently from abe20e1 to e97640d Compare July 26, 2016 13:02
@chadwhitacre chadwhitacre force-pushed the update-some-python-APIs branch 6 times, most recently from 9e5c9bb to 665ee76 Compare July 28, 2016 18:10
@chadwhitacre
Copy link
Contributor Author

Alright, I've rebased and made Travis builds for each commit. Rebasing has GitHub confused, because they list commits in date order instead of DAG order (I've emailed them about it). Here's DAG order.

@chadwhitacre
Copy link
Contributor Author

@Nashe This one is ready for review now that #4094 is in.

@ghost
Copy link

ghost commented Jul 28, 2016

Looks good! #4077 is very close and it'll be huge, awesome work! :-)

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Jul 28, 2016

Yeah! I started dusting off #4025 on the bus this morning, between that and #4077, the end of #3994 is in sight! Can we land it before gratipay/inside.gratipay.com#534 ❗❓ 😮

@mattbk
Copy link
Contributor

mattbk commented Jul 28, 2016

@Nashe, if you're satisfied, you can merge. @whit537 doesn't like merging his own stuff ;-)

@ghost
Copy link

ghost commented Jul 28, 2016

I'm always trying to wait for a second review ;-)

@ghost ghost merged commit 62f3e20 into master Jul 28, 2016
@ghost ghost deleted the update-some-python-APIs branch July 28, 2016 20:10
@chadwhitacre
Copy link
Contributor Author

@Nashe We'll get there! If you weren't here we wouldn't even have one review. 👏 :-)

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants