This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Respect non-searchable users choice when doing a lookup #4090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aims to fix the report [H1-118699](https://hackerone.com/reports/118699): don't search using LIKE on the non-searchable users, but only display them in the list if it's an exact match.
ghost
added
|
Travis is greeting me with a nice:
And their sign-in button just freezes. I'll wait a little bit but I think everything's fine anyway. |
|
Golly! I think we saw that behavior a while ago. I forget where, not finding it in search atm ... maybe @rohitpaulk remembers? |
|
@whit537 It's finally working on my side, sounds like just temporary issues. |
|
Perhaps related to #4077 (comment)? |
|
I guess, yes. |
|
It's obviously more readable now 👍 |
|
Deploying ... |
|
Deployed! :-) |
|
Thanks for your rectification! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to fix the report H1-118699: don't search using LIKE on the non-searchable users, but only display them in the list if it's an exact match.
Some tests were removed since I'm now testing searchable users with/without an exact match and non-searchable users with/without an exact match.