This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
convert client-side tests to Splinter #4079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadwhitacre
force-pushed
the
splinter
branch
2 times, most recently
from
f84cb83 to
ba872d4
Compare
|
Yessssss. ba872d4 passes Travis! 👍 💃 |
|
Ready for review, @aandis @rohitpaulk! :-) |
This was referenced Jul 11, 2016
Merged
| @@ -1,5 +1,6 @@ | |||
| DATABASE_URL="dbname=gratipay-test" | |||
| BASE_URL= | |||
| BASE_URL="" | |||
There was a problem hiding this comment.
Done in 1f27eaf.
|
Rebased on master. Previous head was 1f27eaf |
|
Looks good to me @whit537 . ready for merge.. |
|
Let's wait for github to get back to normal? |
|
Cool. Looks like GitHub is green again! |
|
Reopening to bump Travis. |
|
Alright! We're green. :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3684.
I wanted to write client-side tests for #4077, but I wanted to write more than just a few of them, and I didn't want to write them in our current client-side testing framework.