This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Fix of the Receipt Page #2067 #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please clean up commented code like |
|
@Changaco Can you tell what's going on with the second test failure? It looks like an artifact of how we're working with VCR at Travis. I believe the intention there is to run all tests w/o VCR, actually hitting APIs, yes? |
|
@whit537 The tests are now passing. About VCR and Travis, from what I see in |
| "returning id" | ||
| ) | ||
| url_receipt = '/alice/receipts/{}.html'.format(ex_id) | ||
| #import pdb; pdb.set_trace() |
There was a problem hiding this comment.
Another vestige to remove, @kaguillera.
|
Thanks @Changaco. |
|
Confirmed working locally ttw. |
chadwhitacre
added a commit
that referenced
this pull request
Jul 22, 2014
Fix of the Receipt Page #2067
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the error, test and fix of the Receipt Page. Missing card_type/brand and last4/last_four/number due to the change in the Balanced API