Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

#2457 - Swap Helvetica Neue with Ideal Sans #2535

Merged
merged 5 commits into from
Jul 4, 2014
Merged

Conversation

ESWAT
Copy link

@ESWAT ESWAT commented Jul 2, 2014

WIP Fixes #2457

Things I’ve noticed by just swapping references to Helvetica with Ideal:

  1. The baseline in Ideal Sans is higher than in Helvetiva, so there’s a larger gap in some buttons.
  2. The strokes are thicker in Ideal for the same font-weights compared to Helvetica

idealvshel

So we may have to individually tweak buttons so they look symmetric. As for the strokes we may want to use Ideal Sans Semibold instead of Bold (though this is just my personal preference).

@chadwhitacre
Copy link
Contributor

Rebased on master.

@chadwhitacre
Copy link
Contributor

Let's stick with Bold for now. Once we have Ideal in place I see us making a lot of changes to our typography. I don't think we'll be using bold in the same way. I also want to bring Surveyor in like we have on Building Gittip.

I'm seeing a few tweaks needed; the other big thing we need is to figure out Typography.com's production deployment story.

@chadwhitacre
Copy link
Contributor

I've tweaked a couple places where the font was overflowing. I've also deployed the font set to our CDN and switched to linking to that.

@chadwhitacre
Copy link
Contributor

@ESWAT Wanna review my changes? I'm ready to merge this when you are.

@ESWAT
Copy link
Author

ESWAT commented Jul 4, 2014

@whit537 changes look good. 👍

chadwhitacre added a commit that referenced this pull request Jul 4, 2014
#2457 - Swap Helvetica Neue with Ideal Sans
@chadwhitacre chadwhitacre merged commit e5cb066 into master Jul 4, 2014
@chadwhitacre chadwhitacre deleted the typography-change branch July 4, 2014 12:34
@ericmeltzer
Copy link
Contributor

Hey the new font looks kinda weird on profile pages; the cents a user receives are way bigger than the dollars. Intentional?
screen shot 2014-07-04 at 11 57 13 am

@apetresc
Copy link

apetresc commented Jul 4, 2014

It's not that the cents are bigger, it's just that certain digits in that font extend below the baseline (where normally fonts don't do that). It just depends on which digits appear where; this particular total has the opposite effect, where the dollars appear way bigger:

screenshot 2014-07-04 15 01 55

@ericmeltzer
Copy link
Contributor

Ah, you're right. I find that effect kind of weird, but if it doesn't
bother anyone else, I don't mind either.

On Fri, Jul 4, 2014 at 12:02 PM, Adrian Petrescu [email protected]
wrote:

It's not that the cents are bigger, it's just that certain digits in that
font extend below the baseline (where normally fonts don't do that). It
just depends on which digits appear where; this particular total has the
opposite effect, where the dollars appear way bigger:

[image: screenshot 2014-07-04 15 01 55]
https://cloud.githubusercontent.com/assets/14872/3484540/c79c3c50-03ad-11e4-905b-d7578b61ce19.png


Reply to this email directly or view it on GitHub
#2535 (comment)
.

Eric Meltzer
@wheatpond https://twitter.com/wheatpond
http://theopencompany.net
+1 408 874 6552

@ESWAT
Copy link
Author

ESWAT commented Jul 4, 2014

There might be a non-oldstyle version of Ideal that we can use. I recall there were variants of Ideal but I did not explore what those variants were.

@seanlinsley
Copy link
Contributor

Another issue: Gittip admins who view a team see the navigation bar break to a second line.

screen shot 2014-07-04 at 2 48 53 pm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch to Ideal Sans
5 participants