Add Venmo button #2376
Add Venmo button #2376
Conversation
Should be converted to use our SDK before hitting prod.
Conflicts: templates/connected-accounts.html
| @@ -156,9 +164,6 @@ a.mini-user:hover { | |||
| } | |||
| } | |||
| } | |||
| tr.has-avatar > td { | |||
| vertical-align: bottom; | |||
| } | |||
There was a problem hiding this comment.
This is needed, please add it back, you can use tr.has-avatar > .account-details as selector to prevent the vertical-align: middle on .account-action from being overridden.
There was a problem hiding this comment.
I'm confused why you'd want this? Seems to totally break alignment to me.
Here it is with vertical-align: bottom
and without:
There was a problem hiding this comment.
@thomasboyt The point is to align the platform's name with its logo, per #2265 (comment).
|
The rest of the PR looks okay to me. There are details I would change, but this PR's head is a remote branch so I can't add commits. |
|
@Changaco FWIW, I mildly disagree on the vertical-align styling, but not enough to make a fuss about it. Reintroduced it so this PR can go forward :) |
|
@thomasboyt Thanks for getting back to this! :-) Did a blog post ever land? |
|
Nice! :-) |
Four months after saying a Venmo pay button was "one to two weeks away" in #1922, we've finally gotten around to soft-launching our official button! I'd love for Gittip be one of its first users, since I think it's a much better flow than just linking to a user's profile.
This PR adds the Venmo button to the Venmo row in connected accounts:
You can see the flow in action here (it's undergone a couple of visual tweaks since this):
http://quick.as/6m6s62j
This also fixes #2361.