[1758] Use Python-based SASS library for compilation #1769
Conversation
| @@ -99,7 +99,7 @@ | |||
| background-image: -o-linear-gradient(top, #0088cc, #0077b3); | |||
| background-image: linear-gradient(to bottom, #0088cc, #0077b3); | |||
| background-repeat: repeat-x; | |||
| filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ff0088cc', endColorstr='#ff0077b3', GradientType=0); | |||
| filter: unquote("progid:DXImageTransform.Microsoft.gradient(startColorstr='#ff0088cc', endColorstr='#ff0077b3', GradientType=0)"); | |||
There was a problem hiding this comment.
I was running into error reading values after progid, so here I'm using the workaround mentioned in sass/libsass#72
There was a problem hiding this comment.
Could we live with the fact that IE < 10 would not have the gradient? I know I could 😄 On my sites that would affect around 5% users.
|
I know very little about the setup at heroku but I will test this locally as soon as I get my working tree clean again. I'd like us to have all python solution, thus simplifying our story. |
|
Could you work on a branch in the main repo? It is easier to work with that way (at least for me). Thanks. |
|
I used https://github.com/splitbrain/git-pull-request to work with the PR. Why did you pick this implementation? Is the ruby version using the same engine undercover or is this a completely different implementation? It gives me some warnings during compilation (some uninitialized variables, redefinition of _POSIX_C_SOURCE and maybe others). Does it matter? |
|
What happens in production? Do we rebuild the file with each request? Do we serve the css file through the CDN? |
|
Why are we doing additional jQuery and post_compile changes in this pull request and not in their own pull request? |
This PR uses libsass-python, which is a fork of the C & C++ libsass, but with added Python bindings. The errors that you mention are caused by the C code actually compiling on your machine. I get some myself when compiling, but they don't seem to be a problem.
I'm guessing we rebuild for each request, since we have That's the one problem with this: I don't know if it caches compilation anywhere like the current gem does in |
|
@zwn I added the new envvar to |
|
Alright, this works great for me and tests great if I emulate production and use a pull based cdn. Merging in! @whit537 before you update production talk to me or @seanlinsley |
…pilation [1758] Use Python-based SASS library for compilation
Resolves #1758
use the same library for deployment(in production we setGITTIP_CSS_HREFto point to MaxCDN which caches the request for us)