Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

fix Bountysource regression #1697

Merged
merged 4 commits into from
Nov 27, 2013
Merged

fix Bountysource regression #1697

merged 4 commits into from
Nov 27, 2013

Conversation

chadwhitacre
Copy link
Contributor

No description provided.

@zbynekwinkler
Copy link
Contributor

I haven't had a chance to test it yet. What was the problem? Variable escaping? Does it also address #1020?

@chadwhitacre
Copy link
Contributor Author

@zwn Doesn't address #1020, no. Looking at that now. The problem was a missing www_host attribute on the gittip.elsewhere.bountysource module.

@zbynekwinkler
Copy link
Contributor

@whit537 So it has "never" (I mean a long time) worked? That says something about how often it is used.

@chadwhitacre
Copy link
Contributor Author

@zwn Correct. Though of course we only hear < 10% of the cases where it breaks.

@chadwhitacre
Copy link
Contributor Author

@zwn I included #1020 on here.

zbynekwinkler added a commit that referenced this pull request Nov 27, 2013
@zbynekwinkler zbynekwinkler merged commit 78cbaf9 into master Nov 27, 2013
@zbynekwinkler zbynekwinkler deleted the bountysource-regression branch November 27, 2013 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants