Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

fake name can trip up teams #3722

Closed
chadwhitacre opened this issue Aug 30, 2015 · 5 comments
Closed

fake name can trip up teams #3722

chadwhitacre opened this issue Aug 30, 2015 · 5 comments
Labels

Comments

@chadwhitacre
Copy link
Contributor

In the grand tradition of #3579 and #3697 ...

=================================== FAILURES ===================================
_________________________ TestFakeData.test_fake_data __________________________
self = <test_fake_data.TestFakeData testMethod=test_fake_data>
    def test_fake_data(self):
        num_participants = 5
        num_tips = 5
        num_teams = 1
        num_transfers = 5
>       fake_data.populate_db(self.db, num_participants, num_tips, num_teams, num_transfers)
tests/py/test_fake_data.py:17: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
gratipay/utils/fake_data.py:287: in populate_db
    teams.append(fake_team(db, teamowner))
gratipay/utils/fake_data.py:87: in fake_team
    teamslug = community.slugize(teamslugname)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
slug = "D'Amorebury"
    def slugize(slug):
        """Convert a string to a string for an URL.
        """
>       assert name_pattern.match(slug) is not None
E       AssertionError: assert None is not None
E        +  where None = <built-in method match of _sre.SRE_Pattern object at 0x2b4cece13a58>("D'Amorebury")
E        +    where <built-in method match of _sre.SRE_Pattern object at 0x2b4cece13a58> = name_pattern.match
gratipay/models/community.py:11: AssertionError
----------------------------- Captured stdout call -----------------------------

Discovered on https://travis-ci.org/gratipay/gratipay.com/builds/77886117 for 7306177 (since restarted).

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@chadwhitacre chadwhitacre changed the title squish spurious test failure fake name can trip up teams Jul 12, 2016
@chadwhitacre
Copy link
Contributor Author

Folding #4066 into here ...

One of the fake names is D'Amoreburgh, which is not valid as a team name.

https://travis-ci.org/gratipay/gratipay.com/builds/138331186#L673

@chadwhitacre
Copy link
Contributor Author

@chadwhitacre
Copy link
Contributor Author

@kaguillera Maybe this is a good one for you after #4078 lands?

@kaguillera
Copy link
Contributor

will do

kaguillera added a commit that referenced this issue Jul 21, 2016
kaguillera added a commit that referenced this issue Jul 21, 2016
kaguillera added a commit that referenced this issue Jul 21, 2016
@kaguillera kaguillera mentioned this issue Jul 21, 2016
3 tasks
kaguillera added a commit that referenced this issue Jul 21, 2016
kaguillera added a commit that referenced this issue Aug 3, 2016
kaguillera added a commit that referenced this issue Aug 3, 2016
@kaguillera
Copy link
Contributor

Closing this unless something else comes up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants