Display banner notification about impending credit card expiration

[patcon]

Original issue

Title: Email users about impending credit card expiration

Anonymously suggested via [email protected]:
http://gittip.freshdesk.com/helpdesk/tickets/120

The user only coincidentally noticed that their card was about to expire, and was asking how we could help avoid that situation.

It seems that we could implement this (after we have access to email in #756), but fetching or storing expiration data for each card:
https://docs.balancedpayments.com/1.1/api/cards/#fetch-a-card

---

Revised issue

As per @rummik's suggestion, let's make this about leveraging the banner notifications implemented in #1643

To Do

• research best way to add banner notifications

[alexykot]

Sure, I know gittip doesn't collect emails by default, but I would be happy to give my email to help address the problem.

[rummik]

Shouldn't there be a notification after logging in about their card if it's about to expire?

[patcon]

You mean like using the feature you added here? #1643

That would be great too. Let's make this issue about that, so it's immediately actionable? (I'll revise OP and add a TODO :)

[rummik]

@patcon Something like that, yes :)

[domenkozar]

+1

[mushketyk]

I'll implement this.

[patcon]

Woooo @ivanmushketyk! Need any help? Ask here or drop into #gittip on IRC if you feel like it :)

[Changaco]

@patcon He already is in #gittip.

[mushketyk]

@patcon Thank you, but I think I got how to do it :)

[mushketyk]

@patcon @Changaco I've done some work on this issue and the banner is currently displayed as:

The problem is that now it is displayed every time a user visits any page (this should be very annoying).
I see two ways how to fix that:

1. Show the banner only in the profile page. But in this case the notification can be unnoticed, since a user not often visits his/her profile page?)
2. To store in the database a flag that shows if a user was notified about credit card expiration. The flag can be set to true when user logs in and set to false after the first notification. Therefore a user will be notified about credit card expiration once per log-in. This flag can be stored in 'participants' table or in a new table 'sessions'.

What do you think?

[mushketyk]

Just noticed that the build is broken in my commit. I'll check what I have broken.

[mushketyk]

I think I don't get it. After my changes I receive the following error:

self = <vcr.cassette.Cassette object at 0x2b333a9c9e10>, request = <Request (GET) https://api.balancedpayments.com/customers/CUPeHuJm0IUdoQhklmHIZCM>

    def play_response(self, request):
        '''
            Get the response corresponding to a request, but only if it
            hasn't been played back before, and mark it as playe.d
            '''
        for index, (stored_request, response) in enumerate(self.data):
            if requests_match(request, stored_request, self._match_on):
                if self.play_counts[index] == 0:
                    self.play_counts[index] += 1
                    return response
        # The cassette doesn't contain the request asked for.
        raise UnhandledHTTPRequestError(
            "The cassette (%r) doesn't contain the request (%r) asked for"
>           % (self._path, request)
        )
E       UnhandledHTTPRequestError: "The cassette (u'/home/proger/Projects/gittip/tests/py/fixtures/TestBalancedCard.yml') doesn't contain the request (<Request (GET) https://api.balancedpayments.com/customers/CUPeHuJm0IUdoQhklmHIZCM>) asked for"

I thought that I broke it with changes to gittip/billing/init.py. But after I commented my changes out on my local machine the tests are still failing with the same error.
I am confused, about how my changes could cause this error. Could you please take a look?

[seanlinsley]

@ivanmushketyk could you please open a pull request for your branch?

[mushketyk]

I've fixed the build.

[mushketyk]

@seanlinsley I can, but the work is not yet finished. Did you proposed to open a pull request to help investigate the issue with build (fixed already) or to move discussion about this issue to the pull request comments?

[Changaco]

@ivanmushketyk Adding except: pass is not a proper fix.

[mushketyk]

@Changaco I am sorry. You are right.

[codebykat]

Not sure if this needs a new issue or not, but I noticed this banner today and was annoyed that it warned me (on every single page! including the credit card update page!) but didn't have a freaking link in it to update my credit card info. I had to hunt around on the site to figure out where to update that info. :P

[seanlinsley]

@codebykat that definitely deserves its own ticket

[codebykat]

@seanlinsley #2471 😃