Skip to content
This repository has been archived by the owner on Mar 1, 2021. It is now read-only.

account for 2012-08 #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

account for 2012-08 #6

wants to merge 3 commits into from

Conversation

chadwhitacre
Copy link
Contributor

Builds on 2012-07 (#2).

@chadwhitacre chadwhitacre changed the title 2012-08 reconcile 2012-08 Jan 27, 2016
@chadwhitacre chadwhitacre mentioned this pull request Jan 28, 2016
65 tasks
@chadwhitacre chadwhitacre changed the title reconcile 2012-08 account for 2012-08 Nov 30, 2016
@kaguillera
Copy link
Contributor

This should be up for review soon. Want #2 review and merged before putting the review label on this.

Just noting that I intend on make more PR for the accounting by month even if this takes a while to be reviewed and merged. The idea is that I would have laid the ground work and all I will have to do is make minor changes before it needs to be reviewed and merged.

@kaguillera
Copy link
Contributor

Also I am noting the following here since the #2 comments is long.

We need to change the test.py a bit since it is testing Fee Buffer account which we are no using. I think/believe that we need a test similar to that but not sure what exactly. @whit537 any suggestions? Just let me know what you think an I will make a PR with the necessary changes.

@nobodxbodon
Copy link
Contributor

nobodxbodon commented Feb 24, 2017

As we changed fee-buffer to income/expense in 150c3d0, IMO we don't need to add additional tests, as far as balance sheet is consistent with the statements of all the accounts (maybe that's the test we need to add? like checking the closing (on 08/31) balance in statements with asset of corresponding account in balance sheet?)

@kaguillera
Copy link
Contributor

I was thinking the same thing but just wanted to make sure I was not overlooking anything.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants