This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
Use nomad-native attribute for host IP #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that hashicorp/nomad#12817 is merged in as of Nomad 1.3.2, we should stop using the hax to get the host IP and instead use Nomad's native method to get the host IP.
ghost
self-assigned this
Conflicts: nomad/grapl-core.nomad pulumi/grapl/__main__.py
christophermaier
approved these changes
Aug 18, 2022
nomad/template_smple.json
Outdated
| @@ -0,0 +1,12 @@ | |||
| { | |||
There was a problem hiding this comment.
Was this supposed to have been committed?
colin-grapl
approved these changes
Aug 18, 2022
RM bad code
ghost
force-pushed
the
twunderlich/switch-to-nomad-native-ip
branch
from
1bd7769 to
1e139a7
Compare
This fixes one issue where the Nomad job doesn't accept any variables which results in a KeyError, and speeds up cases where we are not passing in variables
Codecov Report
@@ Coverage Diff @@
## main #1906 +/- ##
==========================================
+ Coverage 43.32% 43.34% +0.01%
==========================================
Files 432 432
Lines 11653 11652 -1
Branches 23 23
==========================================
+ Hits 5049 5050 +1
+ Misses 6589 6587 -2
Partials 15 15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR correspond to?
What changes does this PR make to Grapl? Why?
This switches us to using Nomad's native attribute to get the host IP since Nomad 1.3.2 has been out for over a month
Now that hashicorp/nomad#12817 is merged in as
of Nomad 1.3.2, we should stop using the hax to get the host IP and
instead use Nomad's native method to get the host IP.
How were these changes tested?
Tested locally with make up and checking Jaeger, regression tests may also pick up any issues but I'm not sure if Pulumi/Nomad will pick it up.