Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multi category #92

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Feature/multi category #92

merged 2 commits into from
Aug 8, 2023

Conversation

soad003
Copy link
Member

@soad003 soad003 commented Jul 12, 2023

implements assigning multiple-categories to tags (see issue #91)

soad003 added 2 commits July 12, 2023 13:15
…uce new concepts field to support multiple tag categories (#91), new cli option --tree for taxonomy show command
Copy link
Member

@mdragaschnig mdragaschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, looking good.

Discussion notes:

Hierarchical concepts

In some cases tag concepts extent information, e.g. header-concept "exchange" und tag-concept "cold_wallet", thus both should be kept.

In other cases, header-tag might be omitted because it's less specific than the tag concept, e.g. header-tag "investment_fraud" and tag-concept "pyramid_scheme",

It might be best to stick with the current behaviour and don't try to merge.

Duplicates

(i.e. tags for same address but with differing concepts)

Automatic merging could be done in some cases based on concept tree: less specific tag is deleted (see above, "investment_fraud" vs. "pyramid_scheme").

In other cases (eg.g. "ransomware" vs "phishing" or "market" vs "scam" user intervention might be required.

  • relax deduplication handling algorithm (currently duplicates are deleted without much consideration of their information value)

In the long run: we could provide an interactive script which shows user duplicates and lets them decide if should be merged/what should be deleted

@mdragaschnig mdragaschnig merged commit d66e48d into develop Aug 8, 2023
@mdragaschnig mdragaschnig deleted the feature/multi_category branch August 8, 2023 12:16
@soad003 soad003 restored the feature/multi_category branch December 6, 2024 12:43
@soad003 soad003 deleted the feature/multi_category branch December 6, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants