Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added listing commands for tags, actors and tags having actor labels #67

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Added listing commands for tags, actors and tags having actor labels #67

merged 2 commits into from
Dec 14, 2022

Conversation

cybersec-code
Copy link
Contributor

Added commands for listing tags, actors and tags having actors as labels. Some fixes to the README.md file.

soad003
soad003 approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@soad003 soad003 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes look good. Tested all the new output commands (tagpack list, actorpack list/list_address_actors).

Nits:

  • if possible output csv instead of tuples (easier for post-processing)

mdragaschnig
mdragaschnig approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@mdragaschnig mdragaschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the new commands, looking good.

@mdragaschnig
Copy link
Member 

* if possible output csv instead of tuples (easier for post-processing)

+1

@soad003
Copy link
Member

soad003 commented Dec 14, 2022

I have added a --csv option to all the new commands and harmonized the output. Will merge now.

@soad003 soad003 merged commit 41248c0 into develop Dec 14, 2022
@soad003 soad003 deleted the some_listing_commands branch December 14, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdragaschnig mdragaschnig mdragaschnig approved these changes

@soad003 soad003 soad003 approved these changes

@behas behas Awaiting requested review from behas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cybersec-code @mdragaschnig @soad003