Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalise BCH CashAddr formt to legacy when inserting to tagstore #64

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Normalise BCH CashAddr formt to legacy when inserting to tagstore #64

merged 1 commit into from
Dec 5, 2022

Conversation

mdragaschnig
Copy link
Member

Addresses #56, specifically changes CashAddr to legacy format only when ingesting into the tagstore.

soad003
soad003 requested changes Nov 29, 2022
View reviewed changes
Copy link
Member

@soad003 soad003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

My only request would be to merge into develop instead of master.

cybersec-code
cybersec-code approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@cybersec-code cybersec-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same comment, I think this should be merged into the develop branch. The changes look good to me.

@mdragaschnig
Copy link
Member Author

Thanks for the feedback! and of course I meant develop not master, my bad.

@mdragaschnig mdragaschnig changed the base branch from master to develop December 5, 2022 10:31
@mdragaschnig mdragaschnig merged commit 761bce5 into develop Dec 5, 2022
@mdragaschnig mdragaschnig deleted the issue-56_support_bch_cashaddr_format branch December 5, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soad003 soad003 soad003 requested changes

@cybersec-code cybersec-code cybersec-code approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdragaschnig @soad003 @cybersec-code