Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonise python code standard with graphsense-lib #63

Merged
merged 7 commits into from
Dec 7, 2022

Conversation

soad003
Copy link
Member

@soad003 soad003 commented Nov 25, 2022

The template is based on pyscaffold.

Improvements:

  • Single source of truth for package deps (setup.cfg)
  • Separation of development and runtime dependencies.
  • no need for manifest.in (see)
  • automatic version management via git tags (no _version.py anymore see)

New features:

  • Enforced linting and code formatting and other safety checks on commit (no commit with errors)
  • Automatic documentation (html, latex) generation via sphinx
  • tests for multiple python versions via tox
  • simple upload to pypi and readthedocs if needed.

Todos when moving to new repo (dev):

  • (CAUTION) I would suggest freshly cloning this repo when testing this branch, pre-commit hooks could otherwise mess with the other branches.
  • regenerate config.yaml (path to confidence.csv changed)
  • recreate venv (just to be sure everything works)

Todos when merge:

  • check if git tags are set properly

@soad003 soad003 requested a review from mdragaschnig November 25, 2022 14:32
Copy link
Member

@mdragaschnig mdragaschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a fresh install and testing, looking good.

@mdragaschnig mdragaschnig merged commit 45b2d70 into develop Dec 7, 2022
@mdragaschnig mdragaschnig deleted the feature/harmonize_with_gslib branch December 7, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants