Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize flagging public/private tags #82

Closed
soad003 opened this issue Mar 28, 2023 · 2 comments
Closed

Harmonize flagging public/private tags #82

soad003 opened this issue Mar 28, 2023 · 2 comments
Assignees
@soad003 @mdragaschnig
Labels
enhancement New feature or request

Comments

@soad003
Copy link
Member

soad003 commented Mar 28, 2023

In the tagpack tool we currently have 2 different options regarding marking tagspacks as public on the cli level there is the override flag --public. On the other hand there is the flag is_public directly in the tagpack file, which is confusing.
@soad003 soad003 added the enhancement New feature or request label Mar 28, 2023
@mdragaschnig
Copy link
Member

is_public is an optional Tagpack field, but if it's present, it overrides the commandline option.

@mdragaschnig
Copy link
Member

mdragaschnig commented May 15, 2023 •
edited
Loading

Phase out field in tagpack file: show deprecation warning. Remove from schema in the future

Keep commandline flag.

Update all documentation.

@mdragaschnig mdragaschnig mentioned this issue May 16, 2023
Open
mdragaschnig added a commit that referenced this issue May 16, 2023
@mdragaschnig
Print deprecation warning #82
a77cab0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soad003 soad003

@mdragaschnig mdragaschnig

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@soad003 @mdragaschnig