Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate table design for table address_cluster_mapping #45

Closed
mdragaschnig opened this issue Oct 11, 2022 · 2 comments
Closed

Evaluate table design for table address_cluster_mapping #45

mdragaschnig opened this issue Oct 11, 2022 · 2 comments
Assignees
@mdragaschnig

Comments

@mdragaschnig
Copy link
Member

mdragaschnig commented Oct 11, 2022 •
edited
Loading

The columns

  • gs_cluster_def_addr
  • gs_cluster_in_degr
  • gs_cluster_out_degr

caused a bug that required a fix, but
are not used for tag resolving.

Can we drop them?
@behas
Copy link
Member

behas commented Oct 11, 2022

isn't the definer address used by REST? In any case, I would keep it for the moment because it is useful for identifying clusters. The other two fields can be dropped if @myrho agrees.

@myrho
Copy link
Contributor

myrho commented Oct 11, 2022

The only columns used by the rest service are gs_cluster_id, address and currency

@mdragaschnig mdragaschnig self-assigned this Oct 12, 2022
mdragaschnig added a commit that referenced this issue Oct 13, 2022
@mdragaschnig
remove unnecessary columns #45
9673a01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdragaschnig mdragaschnig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@behas @myrho @mdragaschnig