Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for urql #969

Merged
merged 3 commits into from
Nov 19, 2020
Merged

Update documentation for urql #969

merged 3 commits into from
Nov 19, 2020

Conversation

kitten
Copy link
Contributor

@kitten kitten commented Nov 19, 2020

I've noticed that the entry for urql is actually rather old from back when our bindings were pretty much React exclusive, which isn't the case anymore, so I've added some more notes to bring all the taglines in line (while also making sure that it's consistent across our sites & docs urql-graphql/urql#1177)

I've seen that other libraries expand beyond their shorter description with some more content, so I've shortened and added some content to the urql.md page from our own readme.

The links have been updated to reflect the core packages and go to the documentation directly.

Cheers! 🙌

In our tagline we use "The" on our own pages, and "A" on external
documentation.
Copy link
Member

@carolstran carolstran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeeeeet 🥳

Thanks for taking the time to update this!

@carolstran carolstran merged commit d19e4b4 into graphql:source Nov 19, 2020
@kitten kitten deleted the patch-1 branch November 19, 2020 22:04
@orta
Copy link
Member

orta commented Nov 20, 2020

Perfect

Urigo pushed a commit that referenced this pull request Jan 26, 2021
* Update urql's description and metadata

* Add descriptions as seen for graphql-yoga et al

* Replace "The" with "A"

In our tagline we use "The" on our own pages, and "A" on external
documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants