fix some conflict-types with Graphql #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
will write unit test later ... |
| @@ -65,6 +65,7 @@ var simpleRootValueMutation = mutationWithClientMutationId({ | |||
| type: GraphQLInt | |||
| } | |||
| }, | |||
| // $FlowFixMe: check if Relay narrowed GraphQLResolveInfo.rootValue to Object | |||
There was a problem hiding this comment.
Test does not affect src code ,just suppress it.
It is valid when using a flowType-outputed version of GraphQL .
|
If the fourth commit output |
iamchenxin
force-pushed
the
fixWithGraphql
branch
from
2d0051b to
94c15ff
Compare
This was referenced Jun 6, 2016
This was referenced Jun 6, 2016
|
Just added flow-typed graphql! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checked all conflict flow type between
graphqlandgraphql-relaywithflow-dynamic.See this: not modified any code inside the origin resolver. and will have no produce-time load, when confirmed those data usage are by design.
I use a own copy
graphql(which namedflow-graphql) for temporary type testing. will delete them later. waiting an offcial typedgraphqlpackage.