Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust colours of CodeMirror "Find" dialog on "light" background. #1051

Conversation

abernix
Copy link
Contributor

@abernix abernix commented Jul 5, 2019

This change adjusts the CSS stylings for the colours of the CodeMirror "search" dialog, which appears temporarily when pressing Ctrl-F/Cmd-F within the query or response frames of GraphQL Playground, to be visible within the light theme. It slightly improves the visibility on the dark theme as well!

Before

Note, there is text there, it's just impossible to see!

Screen Shot 2019-07-05 at 16 03 28

After

Screen Shot 2019-07-05 at 16 04 26

After Dark

Screen Shot 2019-07-05 at 16 04 45

Fixes: apollographql/apollo-server#2117

@CLAassistant
Copy link

CLAassistant commented Jul 5, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

abernix added a commit to apollographql/apollo-server that referenced this pull request Jul 5, 2019
To accommodate the change in graphql/graphql-playground#1051.

- `@apollographql/graphql-playground-html`: 1.6.24
- `@apollographql/graphql-playground-react`: 1.7.29

Ref: graphql/graphql-playground#1051
Fixes: #2117
Copy link
Member

@acao acao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this @abernix !

@acao acao merged commit 615b1ae into graphql:master Apr 4, 2021
cgxxv pushed a commit to cgxxv/graphql-playground that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light theme colors for the playground
3 participants