Schema lang descriptions #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| enum __TypeKind { | ||
|
|
There was a problem hiding this comment.
This newline is slightly odd, if I was writing this be hand I'd omit the initial newline.
|
This is awesome! It will make writing schemas with the type language way better, descriptions were one of the biggest missing pieces. |
leebyron
force-pushed
the
schema-lang-descriptions
branch
2 times, most recently
from
ecdd26a to
654c48a
Compare
|
OMG stacked diffs work in github now. |
leebyron
force-pushed
the
schema-lang-descriptions
branch
from
654c48a to
32c66a5
Compare
|
@dschafer - I updated to newline before comment except when it's the first comment in a block/list |
leebyron
force-pushed
the
schema-lang-descriptions
branch
from
32c66a5 to
449992b
Compare
|
Note: I need to add this to extendSchema as well. |
This adds descriptions to the `buildASTSchema` (string->schema) and `schemaPrinter` (schema->string) via walking the previous full-line contiguous comment block. This is dependent on #463.
leebyron
force-pushed
the
schema-lang-descriptions
branch
from
449992b to
208a11f
Compare
This was referenced Sep 23, 2016
This was referenced May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds descriptions to the schema language via docblocks
This adds descriptions to the
buildASTSchema(string->schema) andschemaPrinter(schema->string) via walking the previous full-line contiguous comment block. This is dependent on #463.