Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move errors to GraphQLWrappedError rather than context #4266

Closed
wants to merge 1 commit into from

Conversation

yaacovCR
Copy link
Contributor

  • preserves order of errors with respect to operation
  • bubbling errors mask the non-bubbling errors such that extra information does not leak

- preserves order of errors with respect to operation
- bubbling errors mask the non-bubbling errors such that extra information does not leak
@yaacovCR yaacovCR requested a review from a team as a code owner October 29, 2024 11:07
Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 6a913ce
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6720c1fff05ae90008a6d766
😎 Deploy Preview https://deploy-preview-4266--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR
Copy link
Contributor Author

oddly:

image

@yaacovCR
Copy link
Contributor Author

I have rebased #4264 on top of this PR => both PRs seem individually to lead to a drop in performance for async iterator lists, but when combined, the drop disappears. @JoviDeCroock -- my thought is that the function is very sensitive, and so the benchmark in this case may not be reliable, but that overall if we can make the numbers work, we should be able to merge both PRs, and maybe we should open a separate issue to investigate?

@yaacovCR
Copy link
Contributor Author

was able to remove this from the #4267 stack

@yaacovCR yaacovCR closed this Oct 29, 2024
@yaacovCR yaacovCR deleted the move-errors-to-wrapped-result branch November 1, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant