Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sourcemaps to our published bundles #4231

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

JoviDeCroock
Copy link
Member

Fixes #2470

@JoviDeCroock JoviDeCroock requested a review from a team as a code owner October 13, 2024 15:20
Copy link

netlify bot commented Oct 13, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 9fd1c73
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/670cb194a5437b0008c4f366
😎 Deploy Preview https://deploy-preview-4231--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi @JoviDeCroock, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@JoviDeCroock JoviDeCroock added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Oct 13, 2024
@yaacovCR
Copy link
Contributor

Do we also need to publish the TS source for this to be useful?

@JoviDeCroock
Copy link
Member Author

JoviDeCroock commented Oct 13, 2024

No, sourcemaps should be able to fully standalone do these translations. There is a sourcesContent key in the sourcemap that basically encodes all that information, I should probably check whether TS correctly implements that though.

EDIT: yes that works

@JoviDeCroock JoviDeCroock merged commit a9b18b9 into main Oct 14, 2024
34 checks passed
@yaacovCR yaacovCR deleted the enable-sourcemaps branch October 27, 2024 19:08
@yaacovCR yaacovCR restored the enable-sourcemaps branch October 27, 2024 19:09
@yaacovCR yaacovCR deleted the enable-sourcemaps branch October 27, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants