Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release instructions in CONTRIBUTING.md #4105

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

benjie
Copy link
Member

@benjie benjie commented Jun 12, 2024

npm publish npmDist fails:

$ npm publish npmDist                  
npm ERR! code E404                                                            
npm ERR! 404 Not Found - GET https://registry.npmjs.org/npmDist - Not found                                                                                                                    
npm ERR! 404                                                                  
npm ERR! 404  'npmDist@*' is not in this registry.                            
npm ERR! 404 This package name is not valid, because                                                                                                                                           
npm ERR! 404  1. name can no longer contain capital letters                   
npm ERR! 404                                                                  
npm ERR! 404 Note that you can also install from a                            
npm ERR! 404 tarball, folder, http url, or git url.  

However cd npmDist && npm publish works.

I've also fixed the releases URL, and added the npm run changelog command with final instruction.

Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 7c03776
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6669b3987e12160008913a0a
😎 Deploy Preview https://deploy-preview-4105--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi @benjie, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@benjie
Copy link
Member Author

benjie commented Jun 12, 2024

We should probably also note somewhere that the releasing user needs to have Docker installed and docker run hello-world should work without error.

@benjie benjie merged commit 07d5025 into main Jun 12, 2024
35 checks passed
@benjie benjie deleted the release-instructions branch June 12, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant