Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve directive tests #3775

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Improve directive tests #3775

merged 1 commit into from
Sep 26, 2024

Conversation

andimarek
Copy link
Contributor

Improving directive tests by adding a new example for directives used on other directive arguments:

          directive @myDirective(arg:String) on ARGUMENT_DEFINITION 
          directive @myDirective2(arg:String @myDirective) on FIELD 

As far as I could see that was not clearly documented through tests before.

@netlify
Copy link

netlify bot commented Nov 12, 2022

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit a9d6b3c
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/636eee628b2cf80008ae312f
😎 Deploy Preview https://deploy-preview-3775--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Hi @andimarek, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Sep 26, 2024
@yaacovCR yaacovCR merged commit 33cb7b9 into main Sep 26, 2024
@yaacovCR yaacovCR deleted the directive-on-directive-test branch September 26, 2024 21:49
@andimarek
Copy link
Contributor Author

Thanks a lot for merging, especially after such long time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants