-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stream): allow initialValue of zero #2979
Conversation
e0e3cad
to
2caec2d
Compare
6d08565
to
38f678c
Compare
I am not sure why the flow integration tests fail -- they pass if we bump the flow version used in integration tests to 0.142 to match the base repo. On the other hand, if I downgrade the base repo to 0.135, it triggers the following seemingly unrelated errors:
|
huh. and now integration tests are passing again. wierd. |
I didn't bother adding an additional test -- the existing code was not allowing an asynciterator to stream initialValues=0, was always acting as if initialValues was at least 1. |
@robrichard @IvanGoncharov ready for review |
@yaacovCR can you add a test for this case? |
Sure |
Done |
No description provided.