Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for explicitly mentioning ObjectTypes #1679

Merged
merged 6 commits into from
Jan 29, 2019
Merged

Documentation for explicitly mentioning ObjectTypes #1679

merged 6 commits into from
Jan 29, 2019

Conversation

elevenpassin
Copy link
Contributor

Based on the discussion at #1413

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

IvanGoncharov
IvanGoncharov requested changes Jan 21, 2019
View reviewed changes
@elevenpassin
Edit example doc for schema definition
2f29b4b 
- provide more clear example /w interfaces & types
- rewrite to note with more clarity
- move the note above the note on directives
IvanGoncharov
IvanGoncharov reviewed Jan 21, 2019
View reviewed changes
IvanGoncharov
IvanGoncharov reviewed Jan 21, 2019
View reviewed changes
IvanGoncharov
IvanGoncharov reviewed Jan 22, 2019
View reviewed changes
IvanGoncharov
IvanGoncharov approved these changes Jan 22, 2019
View reviewed changes
Copy link
Member

@IvanGoncharov IvanGoncharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 👍
However it would be great if native speaker will review it just to be sure.
@mjmahone @Neitsch Can you please review?

@IvanGoncharov IvanGoncharov merged commit f1c9b82 into graphql:master Jan 29, 2019
@IvanGoncharov
Copy link
Member

@buoyantair Merged 🎉 Thanks for PR 👍

@IvanGoncharov IvanGoncharov mentioned this pull request Jan 29, 2019
Closed
@elevenpassin elevenpassin deleted the doc/1413 branch January 30, 2019 08:46
@snyk-bot snyk-bot mentioned this pull request Aug 31, 2019
Merged
@ab-pm
Copy link

ab-pm commented May 28, 2024

Unfortunately this change didn't arrive in the documentation at https://graphql.org/graphql-js/type/#graphqlschema. Is there something else that needs to be done for that?

@yaacovCR yaacovCR mentioned this pull request Oct 11, 2024
Merged
yaacovCR added a commit that referenced this pull request Oct 11, 2024
@yaacovCR
add toConfig tests (#4225)
ace6727 
would address #1679 

I think a simpler version than #1683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanGoncharov IvanGoncharov IvanGoncharov approved these changes

Assignees
No one assigned
Labels
CLA Signed PR: docs 📝
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elevenpassin @facebook-github-bot @IvanGoncharov @ab-pm