Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14.0.0-rc.1 #1364

Merged
merged 1 commit into from
Jun 7, 2018
Merged

14.0.0-rc.1 #1364

merged 1 commit into from
Jun 7, 2018

Conversation

mjmahone
Copy link
Contributor

@mjmahone mjmahone commented Jun 4, 2018

No description provided.

@IvanGoncharov
Copy link
Member

@mjmahone I'm working on #1324 which is breaking change and I think it should be in rc.1. Can you please wait a day?

@IvanGoncharov
Copy link
Member

I also wanted to include #1322 since it's almost ready and makes graphql-js spec compliant.

@mjmahone
Copy link
Contributor Author

mjmahone commented Jun 4, 2018

@IvanGoncharov yes it can wait a day. I wanted to put this up to make clear the 14.0 release is coming soon. I'm also OK merging breaking changes until we're off -rc versions, so if there's something that we really want that will take more than a day to fix, we can wait a week or so. I'll start canarying the 14.0 release with FB's codebase with each -rc though. I'd like to root out any major upgrade issues prior to 14.0.0 (non-rc).

@IvanGoncharov
Copy link
Member

@mjmahone I caught the flu 🤒 so it will take me more time than I initially planned.
So probably it makes sense to release RC1 as the smoke test for already committed changes.

@IvanGoncharov
Copy link
Member

IvanGoncharov commented Jun 5, 2018

@mjmahone My strategy right now is to open PR for all breaking changes on my list so I could get feedback from you and community. I still have a couple items on my list so I focused on opening new PRs.

Sorry for the delay in answering some of your questions on existing PRs they just they require detailed answers and I will try to give them during next couple of days.

@mjmahone
Copy link
Contributor Author

mjmahone commented Jun 7, 2018

@IvanGoncharov Please focus on getting better! Your health is more important than us pushing this out a week earlier. I'm happy to get the RC out and wait a week or two extra to switch us from RC to release (with the assumption there will be breaking changes between those) if it means you have time to focus on your own wellness.

If needed I can pull someone else into this effort: if you have a list of PRs you think we should consider pulling in, I'll make sure to get extra eyes on anything I don't feel confident about.

@mjmahone
Copy link
Contributor Author

mjmahone commented Jun 7, 2018

Alright, I'm going to merge the RC v1 now. If you're a third-party library used by others who may also use graphql-js, I do not recommend take a dependency on this RC: there will be a few additional breaking changes, such as a fix for #1324 .

I'm going to use this RC to smoke out issues across a variety of Facebook libraries, which should hopefully make the upgrade process easier. For instance, I'll make sure https://github.com/facebook/relay works with this RC prior to releasing 14.0.

@mjmahone mjmahone merged commit 84f41aa into master Jun 7, 2018
@mjmahone mjmahone deleted the version-14-rc branch June 7, 2018 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants