Execute: use consistent name for execution context #1318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebyron
requested changes
Apr 23, 2018
src/execution/execute.js
Outdated
| @@ -378,9 +378,9 @@ export function buildExecutionContext( | |||
| */ | |||
| function executeOperation( | |||
| exeContext: ExecutionContext, | |||
| operation: OperationDefinitionNode, | |||
There was a problem hiding this comment.
The existing function signature was easier to understand - executeOperation() should accept an operation.
leebyron
approved these changes
Apr 23, 2018
|
Similarly, user-provided context should always appear as |
leebyron
added a commit
that referenced
this pull request
Apr 23, 2018
commit b58697d8e91de91265cbebe48906e0c29b48b28b Author: Lee Byron <[email protected]> Date: Mon Apr 23 16:50:02 2018 -0400 Also unify contextValue commit 30d062cedd687c1f662d9e87e08d35d61c2a50ce Merge: 1d07ebf 4db01f3 Author: Lee Byron <[email protected]> Date: Mon Apr 23 16:47:31 2018 -0400 Merge branch 'exeContextName' of https://github.com/APIs-guru/graphql-js into APIs-guru-exeContextName commit 4db01f3 Author: Lee Byron <[email protected]> Date: Mon Apr 23 13:43:20 2018 -0700 Addendum commit 571f2bc Author: Lee Byron <[email protected]> Date: Mon Apr 23 13:42:41 2018 -0700 Address review commit 0195b30 Author: Ivan Goncharov <[email protected]> Date: Sat Apr 21 17:30:35 2018 +0300 Execute: use consistent name for execution context
|
I merged in the contextValue change as well :) |
This was referenced Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It helps to easily distinguish between user-provided context and execution context.