Add support for Symbol.toStringTag #1297

nyteshade · 2018-03-23T00:53:16Z

Changes

Add static and instance property getters for Symbol.toStringTag for
each exported class.

Purpose
Being able to compare class and class instances via internal class type
as per the definition and usage of Symbol.toStringTag allows other
libraries to validate types during runtime in this manner. It also
prevents them from having to patch the live values in their own
codebases.

Contrived Example
With no modules and vanilla JavaScript we should be able to do something
like the following.

let type = new GraphQLObjectType({name: 'Sample'});

if (({}).toString.call(type) === '[object GraphQLObjectType]') {
  // we have the right type of class
}

However, with libraries such as type-detect or ne-types the code can
look far cleaner.

// type-detect
let type = require('type-detect')
let obj = new GraphQLObjectType({name:'Example'})
assert(type(obj) === GraphQLObjectType.name)

// ne-types
let { typeOf } = require('ne-types')
let obj = new GraphQLObjectType({name:'Example'})
assert(typeOf(obj) === GraphQLObjectType.name)

There are a lot of libraries out there, despite doing nearly the same
thing in all cases, that support the usage of Symbol.toStringTag and
by adding support for that in the base GraphQL classes, all of these
libraries can be used with GraphQL.

Note: I would have used get [Symbol.toStringTag]() { ... } style programming instead, but the linters threw errors about computed types. So I used ES5 style Object.defineProperty calls instead.

facebook-github-bot · 2018-03-23T00:53:58Z

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email [email protected] with your details so we can update your status.

nyteshade · 2018-03-24T19:54:52Z

@facebook-github-bot I've sent a few [email protected] emails but your message persists

IvanGoncharov · 2018-03-26T14:01:51Z

@nyteshade Thanks for PR 👍
The similar issue was previously discussed here: #491 (comment)
Problem is that graphql-js mostly used as one of peerDependencies so there is a very high risk that developer accidentally uses multiple instances of this lib and checks that depend on a class name is not reliable in such case.

Moreover, many popular tools mangle class names (e.g. UglifyJS) this will introduce even more confusing when typeOf will return two different strings for two enums created by different copies of this lib. We had this problem previously see #1174.

So the safest approach is to use predicate functions like isDirective, isType, etc. See #1137 for the complete list.

nyteshade · 2018-03-26T20:06:28Z

@IvanGoncharov

Thanks for your time and for responding. I understand that need to try to protect engineers from the community from stubbing their toes on common pitfalls; such as having multiple versions of graphql installed in their projects.

Whenever we write libraries for the public we often have to toe the line of being opinionated or not when it it comes to how they should use the code we provide. I would argue that the PR should still be allowed in for a few reasons.

Those folks who use Object.prototype.toString.call/apply and/or Symbol.toStringTag are usually aware of issues that can crop up from having multiple instances of library installed and choose to continue regardless.
Recent versions of yarn and npm are good at flattening the node_modules directory in such a manner as to prevent multiple installations as much as possible.
Finally, you are absolutely correct that certain tools such as Uglify Js do indeed mung the names of things but it only really matters if the compilation tool used in this library does so and that can be controlled.
Providing the JavaScript community to use the tools to available to them and the coding styles their teams and companies prefer

Additionally, something like this could be added to the graphql-js page.

GraphQL JS and Symbol.toStringTag
We are aware that some engineers prefer to do type detection that relies on Symbol.toStringTag. We at Facebook want to provide ways to do that with the graphql-js library. In doing so, we would like to make you aware of a common pitfall in doing so. If you have multiple versions of GraphQL installed, checking for specific instances can cause problems. You are forewarned.

IvanGoncharov · 2018-03-27T20:00:45Z

@nyteshade Nice set of arguments 👍
I think to support Symbol.toStringTag has it's pros and cons so it should be an architectural decision by @leebyron
Also, it would be great if you could provide a code example that would benefit from Symbol.toStringTag vs library specific predicates (isDirective, isType, ...).

leebyron

I left some tactical feedback on the code itself. I don't see anything wrong with this change in that it offers a small convenience during debugging.

However I do agree that using toString for object type detection is a brittle pattern that breaks in minified code and suffers from some string manipulation performance overhead so is probably only suitable for test environments. We should still encourage the use of GraphQL.js's predicate functions for any code that might see a production environment.

leebyron · 2018-03-27T20:24:54Z

src/language/source.js

@@ -41,3 +41,15 @@ export class Source {
    );
  }
 }
+
+Object.defineProperty(Source, Symbol.toStringTag, {


Why add this to the constructor itself? Shouldn't only instances be encountered? Also, wouldn't this produce confusing results? I would expect a constructor function to toString as a function

leebyron · 2018-03-27T20:25:33Z

src/language/source.js

+  },
+});
+
+Object.defineProperty(Source.prototype, Symbol.toStringTag, {


Should this only occur in a if (typeof Symbol === 'function' && Symbol.toStringTag) check? Otherwise if embedded in an older node or browser context, this could throw

leebyron · 2018-03-27T20:26:35Z

src/type/definition.js

+  get() {
+    return this.constructor.name;
+  },
+});


I'm noticing this implementation is identical for all types. Perhaps a function in jsutils to reduce code duplication?

nyteshade · 2018-03-30T00:53:37Z

Thanks @leebyron, I'll make the requested changes and update the PR.

facebook-github-bot · 2018-04-04T02:22:19Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

IvanGoncharov · 2018-05-24T12:37:23Z

Hi @nyteshade,

Do you need any help with this PR?
We are planning to release 14.0.0 and it would be great to include this PR.

nyteshade · 2018-05-24T16:36:14Z

@IvanGoncharov nope, thanks, life just got in the way and I forgot. I'll clean it up and resubmit for review in the next 48 hours. When is 14 slated for release?

IvanGoncharov · 2018-05-24T20:37:33Z

I'll clean it up and resubmit for review in the next 48 hours. When is 14 slated for release?

No need to hurry there is no fixed date at the moment, I just reviewing issues/PRs for low-hanging fruits.
Some context here: #1346

nyteshade · 2018-05-25T06:52:49Z

Off to bed, but, @IvanGoncharov, @leebyron, I'm hoping these changes are more towards everyones' liking. I'll check back later and see if coveralls ever finished.

IvanGoncharov · 2018-05-25T14:57:45Z

@nyteshade Can you please do git rebase on this PR?
Since it's very hard to review: https://github.com/graphql/graphql-js/pull/1297/files

I'll check back later and see if coveralls ever finished.

It looks like I broke coveralls 😞 I will try to figure out whats wrong.

nyteshade · 2018-05-25T19:24:30Z

@IvanGoncharov Should be better now. Placed it all in one commit. @leebyron I believe I have addressed all your feedback.

IvanGoncharov · 2018-05-27T00:10:30Z

src/jsutils/__tests__/symbolSupport-test.js

+    process.version,
+  );
+
+  it('should have Symbol in scope if the version >= 4.9.1', () => {


@nyteshade We dropped support for Node 4 in master

IvanGoncharov · 2018-05-27T00:12:35Z

package-lock.json

@@ -0,0 +1,8370 @@
+{


Can you please remove this file?

IvanGoncharov · 2018-05-27T00:43:24Z

src/jsutils/__tests__/symbolSupport-test.js

+    expect(hasSymbolSupport()).to.equal(true);
+  });
+
+  it('should have Symbol in scope if the version >= 6.4.0', () => {


I checked and looks like it supported since 6.0.0:
https://node.green/#ES2015-built-ins-well-known-symbols-Symbol-toStringTag

Given that package.json requires >=6.0.0:

graphql-js/package.json

Line 21 in 0a30b62

"node": "6.x || 8.x || 9.x || >= 10.x"

Please remove two above tests.

IvanGoncharov · 2018-05-27T00:47:07Z

src/jsutils/symbolSupport.js

+ * `toStringTag` is set on the `Symbol` class and it maps to an instance of
+ * `Symbol`. False in all other cases
+ */
+export function hasSymbolSupport(specificSymbol?: string): boolean {


Since hasSymbolSupport was used only by test that would be removed you don't need to export this function anymore.
This allows making applyToStringTag default export similar to all other jsutils/* files.
+ it would make sense to rename this file into applyToStringTag.js

IvanGoncharov · 2018-05-27T00:59:50Z

src/jsutils/symbolSupport.js

+    // comparing Symbol instance rather than the string resulting from a call
+    // to typeof.
+    //
+    // Le sigh....


I think it's premature generalization to create hasSymbolSupport since inside applyToStringTag you can write:

if (typeof Symbol === 'function' && typeof Symbol.toStringTag === 'symbol') { Object.defineProperty(...) }

+ it passes Flow

This doesn't work exactly as you've typed but a variant in the PR does what you've asked for. I believe the issue here has some fundamental conflict with using typeof with Symbol.

nyteshade · 2018-05-29T03:37:28Z

@IvanGoncharov; your requested changes have been made.

IvanGoncharov · 2018-05-29T14:43:39Z

@nyteshade Thanks 👍 Last issue from me, please remove package-lock.json:

**Changes** * Add static and instance property getters for Symbol.toStringTag for each exported class. **Purpose** Being able to compare class and class instances via internal class type as per the definition and usage of Symbol.toStringTag allows other libraries to validate types during runtime in this manner. It also prevents them from having to patch the live values in their own codebases. **Contrived Example** With no modules and vanilla JavaScript we should be able to do something like the following. ```javascript let type = new GraphQLObjectType({name: 'Sample'}); if (({}).toString.call(type) === '[object GraphQLObjectType]') { // we have the right type of class } ``` However, with libraries such as `type-detect` or `ne-types` the code can look far cleaner. ```javascript // type-detect let type = require('type-detect') let obj = new GraphQLObjectType({name:'Example'}) assert(type(obj) === GraphQLObjectType.name) // ne-types let { typeOf } = require('ne-types') let obj = new GraphQLObjectType({name:'Example'}) assert(typeOf(obj) === GraphQLObjectType.name) ``` There are a lot of libraries out there, despite doing nearly the same thing in all cases, that support the usage of `Symbol.toStringTag` and by adding support for that in the base GraphQL classes, all of these libraries can be used with GraphQL.

nyteshade · 2018-05-29T23:06:52Z

@IvanGoncharov Whoops! Forgot to remove it. Done ✅

nyteshade · 2018-05-31T20:15:11Z

@leebyron ?

IvanGoncharov · 2018-06-04T19:01:59Z

@mjmahone I think all @leebyron comments were address and this PR is ready to be merged. Can you please review it?

mjmahone · 2018-06-04T23:42:56Z

Yup it looks good. Thank you @nyteshade !

nyteshade · 2018-06-04T23:43:34Z

My pleasure @mjmahone

## Version **14.0.0** of **graphql** was just published. <table> <tr> <th align=left> Dependency </th> <td> <a target=_blank href=https://github.com/graphql/graphql-js>graphql</a> </td> </tr> <tr> <th align=left> Current Version </th> <td> 0.13.2 </td> </tr> <tr> <th align=left> Type </th> <td> dependency </td> </tr> </table> The version **14.0.0** is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. It might be worth looking into these changes and trying to get this project onto the latest version of graphql. If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update. --- <details> <summary>Release Notes</summary> v14.0.0 Breaking: <ul> <li>Drops support for node v4 and v9, makes sure node v10 is supported (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="320331530" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1338" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1338">#1338</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="347064508" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1445" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1445">#1445</a>)</li> <li>Reject invalid scalar value coercion (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="329203491" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1365" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1365">#1365</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="320302933" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1336" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1336">#1336</a>)</li> <li>Removes <code>VariablesDefaultValueAllowed</code> validation rule, and <code>ProvidedNonNullArguments</code> became <code>ProvidedRequiredArguments</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="302567815" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1274" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1274">#1274</a>)</li> <li>Stricter coercion of Scalar Types (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="331077407" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1382" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1382">#1382</a>)</li> <li>Removes deprecated Introspection fields <code>onOperation</code>, <code>onFragment</code>, and <code>onField</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="331430870" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1385" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1385">#1385</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="343635964" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1429" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1429">#1429</a>)</li> <li><code>GraphQL*Config</code> are now exact types (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="331763019" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1391" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1391">#1391</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="347050549" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1443" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1443">#1443</a>)</li> <li>"Schema Change" keys in <code>BreakingChangeType</code> and <code>DangerousChangeType</code> for detecting adding args and input fields changed name (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="355220055" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1492" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1492">#1492</a>)</li> <li><code>formatError</code> API changed for error message extensions. To upgrade without changing existing server responses, wrap <code>graphql</code>'s <code>formatError</code>:</li> </ul> <pre><code>import { formatError as baseFormatError, /* ... */ } from 'graphql'; { // other options formatError(error) { const { extensions, ...rest } = baseFormatError(error); return { ...extensions, ...rest }; }, } </code></pre> New: <ul> <li>Parse new schema extensions (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="315664664" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1314" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1314">#1314</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="317012679" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1323" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1323">#1323</a>)</li> <li>Export SDL AST types (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="315694355" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1315" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1315">#1315</a>)</li> <li><code>extendSchema</code> extended with spec-compliant SDL extensions (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="330426164" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1373" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1373">#1373</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="331961053" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1392" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1392">#1392</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="346266873" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1441" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1441">#1441</a>)</li> <li><code>symbol.toStringTag</code> support (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="307864327" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1297" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1297">#1297</a>)</li> <li>Expose <code>getOperationRootType(schema, operationAST)</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="322058451" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1345" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1345">#1345</a>)</li> <li>Package is marked as side-effect free (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="314458450" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1312" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1312">#1312</a>)</li> <li><code>validateSchema</code> works with Schema extensions (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="337240645" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1410" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1410">#1410</a>)</li> <li><code>validate</code> works on SDL definitions (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="345971682" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1438" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1438">#1438</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="331081195" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1383" href="https://urls.greenkeeper.io/graphql/graphql-js/issues/1383">#1383</a>)</li> <li>directives can be added to variable definitions, behind <code>experimentalVariableDefinitionDirectives</code> flag (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="345484247" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1437" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1437">#1437</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="348424943" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1454" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1454">#1454</a>)</li> <li>ASTNode predicates, like <code>isDefinitionNode</code> and <code>isTypeSystemDefinitionNode</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="349160476" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1459" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1459">#1459</a>)</li> <li><code>isRequiredArgument</code> and <code>isRequiredInputField</code> predicates (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="349831716" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1463" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1463">#1463</a>)</li> </ul> Fixed: <ul> <li>Fixes for custom enum types</li> <li>Prettier, Flow and eslint upgrades (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="310208412" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1304" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1304">#1304</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="316500173" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1319" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1319">#1319</a>)</li> <li>Babel 7 upgrade (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="323277037" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1350" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1350">#1350</a>)</li> <li>Introspection query perf improved (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="318663971" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1329" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1329">#1329</a>)</li> <li><code>introspectionFromSchema</code> has default options (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="336268824" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1408" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1408">#1408</a>)</li> <li><code>buildSchema</code> memory leaks and infinite recursion fixed (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="341094161" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1417" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1417">#1417</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="343182956" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1427" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1427">#1427</a>)</li> <li><code>watch</code> command fixed (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="347719430" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1449" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1449">#1449</a>)</li> <li>Benchmarking for <code>validation</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="350893741" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1471" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1471">#1471</a>)</li> </ul> Deprecated: These will be removed in v15 <ul> <li><code>introspectionQuery</code>, use <code>getIntrospectionQuery</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="331432132" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1386" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1386">#1386</a>)</li> <li><code>getDescription</code>, use the schema AST node to get descriptions (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="333742859" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1396" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1396">#1396</a>)</li> <li><code>isValidJSValue</code>, use <code>coerceValue</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="331432132" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1386" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1386">#1386</a>)</li> <li><code>isValidLiteralValue</code>, use validation (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="331432132" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1386" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1386">#1386</a>)</li> </ul> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴

## Version **14.0.0-rc.1** of [graphql](https://github.com/graphql/graphql-js) was just published. <table> <tr> <th align=left> Dependency </th> <td> <code>graphql</code> </td> </tr> <tr> <th align=left> Current Version </th> <td> 0.13.2 </td> </tr> <tr> <th align=left> Type </th> <td> dependency </td> </tr> </table> The version **14.0.0-rc.1** is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. It might be worth looking into these changes and trying to get this project onto the latest version of graphql. If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update. --- <details> <summary>Release Notes</summary> v14.0.0-rc.1 NOTE This is a pre-release. There is a high likelihood there will be more breaking changes introduced prior to the <code>14.0.0</code> release. Breaking: <ul> <li>Drops support for node v4, makes sure node v10 is supported (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="320331530" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1338" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1338">#1338</a>)</li> <li>Reject invalid scalar value coercion (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="329203491" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1365" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1365">#1365</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="320302933" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1336" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1336">#1336</a>)</li> <li>Removes <code>VariablesDefaultValueAllowed</code> validation rule, and <code>ProvidedNonNullArguments</code> became <code>ProvidedRequiredArguments</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="302567815" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1274" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1274">#1274</a>)</li> </ul> New: <ul> <li>Parse new schema extensions (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="315664664" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1314" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1314">#1314</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="317012679" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1323" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1323">#1323</a>)</li> <li>Export SDL AST types (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="315694355" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1315" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1315">#1315</a>)</li> <li><code>extendSchema</code> extended with spec-compliant SDL extensions (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="330426164" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1373" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1373">#1373</a>)</li> <li><code>symbol.toStringTag</code> support (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="307864327" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1297" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1297">#1297</a>)</li> <li>Expose <code>getOperationRootType(schema, operationAST)</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="322058451" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1345" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1345">#1345</a>)</li> <li>Package is marked as side-effect free (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="314458450" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1312" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1312">#1312</a>)</li> </ul> Fixed: <ul> <li>Fixes for custom enum types</li> <li>Prettier, Flow and eslint upgrades (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="310208412" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1304" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1304">#1304</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="316500173" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1319" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1319">#1319</a>)</li> <li>Babel 7 upgrade (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="323277037" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1350" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1350">#1350</a>)</li> <li>Introspection query perf improved (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="318663971" data-permission-text="Issue title is private" data-url="graphql/graphql-js#1329" href="https://urls.greenkeeper.io/graphql/graphql-js/pull/1329">#1329</a>)</li> </ul> </details> <details> <summary>Commits</summary> The new version differs by 56 commits. <ul> <li><a href="https://urls.greenkeeper.io/graphql/graphql-js/commit/84f41aadcfe3f86833d3f37914c995416091d9f1"><code>84f41aa</code></a> <code>14.0.0-rc.1 (#1364)</code></li> <li><a href="https://urls.greenkeeper.io/graphql/graphql-js/commit/45ecb530eff5c44327a13bac355513dc6a38aff8"><code>45ecb53</code></a> <code>Merge extendType functionality changes from #1322 (#1373)</code></li> <li><a href="https://urls.greenkeeper.io/graphql/graphql-js/commit/43c0d46ac9a279a1c3be9c8592381e2a99eec209"><code>43c0d46</code></a> <code>fix imports (#1372)</code></li> <li><a href="https://urls.greenkeeper.io/graphql/graphql-js/commit/f9b0bae8c3d0b289617136442adc9b4bfbf5c21c"><code>f9b0bae</code></a> <code>Add simple test for <code>instanceOf</code>. (#1370)</code></li> <li><a href="https://urls.greenkeeper.io/graphql/graphql-js/commit/ae23c901c5699287c3e870a6fc7d6180049a8eb9"><code>ae23c90</code></a> <code>Handle NaN as input value (#1369)</code></li> <li><a href="https://urls.greenkeeper.io/graphql/graphql-js/commit/85971a277c4e7782e9be38d102bd6562dedf7804"><code>85971a2</code></a> <code>Add test for enum custom values as input args (#1267)</code></li> <li><a href="https://urls.greenkeeper.io/graphql/graphql-js/commit/3473ca53517f6df9a3b02a744bcc56f2de097710"><code>3473ca5</code></a> <code>Reject Infinity supplied as Int or Float value (#1365)</code></li> <li><a href="https://urls.greenkeeper.io/graphql/graphql-js/commit/85b4f580c5fe9efe8baf8433d78ca9607f302b2e"><code>85b4f58</code></a> <code>__allowedLegacyNames: Use empty array instead of undefined properties (#1259)</code></li> <li><a href="https://urls.greenkeeper.io/graphql/graphql-js/commit/e79faaa5c440edbb5aed885f49bfdd13130966dd"><code>e79faaa</code></a> <code>Add support for Symbol.toStringTag (#1297)</code></li> <li><a href="https://urls.greenkeeper.io/graphql/graphql-js/commit/10e80d05dcad55e0e08806512250c65ed55fcfc8"><code>10e80d0</code></a> <code>instanceOf: Check that one of the names in non-empty string (#1357)</code></li> <li><a href="https://urls.greenkeeper.io/graphql/graphql-js/commit/bc03768b4b3ca181af163bdb8616ee0c46ef7be3"><code>bc03768</code></a> <code>Upgrade babel and associated plugins to v7 (#1350)</code></li> <li><a href="https://urls.greenkeeper.io/graphql/graphql-js/commit/68577079930e24da9c25b6c3f8fcadd488d94014"><code>6857707</code></a> <code>Scalars: reject array serialization/coercion (#1336)</code></li> <li><a href="https://urls.greenkeeper.io/graphql/graphql-js/commit/ddb3ffc57ecccefa3e66357b6e948e3ba75af411"><code>ddb3ffc</code></a> <code>Updated Flow, Prettier and other dependencies (#1362)</code></li> <li><a href="https://urls.greenkeeper.io/graphql/graphql-js/commit/eb8ef7afd8f9c5c833ee413b98284221058feac0"><code>eb8ef7a</code></a> <code>Babel 7 preparation: Switch babel config to JS (#1348)</code></li> <li><a href="https://urls.greenkeeper.io/graphql/graphql-js/commit/324768a6aaf68dd6667b888a6e151d4c47ec7073"><code>324768a</code></a> <code>Errors: fix how error messages represent arrays (#1333)</code></li> </ul> There are 56 commits in total. See the <a href="https://urls.greenkeeper.io/graphql/graphql-js/compare/f995c1f92e94d9c451104b6a0db8034165ef8640...84f41aadcfe3f86833d3f37914c995416091d9f1">full diff</a> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴

leebyron requested changes Mar 27, 2018

View reviewed changes

facebook-github-bot added the CLA Signed label Apr 4, 2018

nyteshade force-pushed the master branch from f95dbb5 to 1c5bd38 Compare May 25, 2018 19:23

IvanGoncharov reviewed May 27, 2018

View reviewed changes

package-lock.json Outdated

@@ -0,0 +1,8370 @@

{

Copy link

Member

IvanGoncharov May 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove this file?

IvanGoncharov reviewed May 27, 2018

View reviewed changes

nyteshade force-pushed the master branch from 1c5bd38 to 71a6669 Compare May 29, 2018 03:31

nyteshade force-pushed the master branch from 71a6669 to 44c8adc Compare May 29, 2018 23:05

IvanGoncharov approved these changes May 31, 2018

View reviewed changes

mjmahone merged commit e79faaa into graphql:master Jun 4, 2018

leebyron added a commit that referenced this pull request Jun 11, 2018

Simplify #1297

023c555

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Symbol.toStringTag #1297

Add support for Symbol.toStringTag #1297

nyteshade commented Mar 23, 2018

facebook-github-bot commented Mar 23, 2018

nyteshade commented Mar 24, 2018

IvanGoncharov commented Mar 26, 2018

nyteshade commented Mar 26, 2018

IvanGoncharov commented Mar 27, 2018

leebyron left a comment

leebyron Mar 27, 2018

leebyron Mar 27, 2018

leebyron Mar 27, 2018

nyteshade commented Mar 30, 2018

facebook-github-bot commented Apr 4, 2018

IvanGoncharov commented May 24, 2018 •

edited

Loading

nyteshade commented May 24, 2018

IvanGoncharov commented May 24, 2018

nyteshade commented May 25, 2018

IvanGoncharov commented May 25, 2018

nyteshade commented May 25, 2018 •

edited

Loading

IvanGoncharov May 27, 2018 •

edited

Loading

IvanGoncharov May 27, 2018

IvanGoncharov May 27, 2018

IvanGoncharov May 27, 2018

IvanGoncharov May 27, 2018

nyteshade May 29, 2018

nyteshade commented May 29, 2018

IvanGoncharov commented May 29, 2018

nyteshade commented May 29, 2018

nyteshade commented May 31, 2018

IvanGoncharov commented Jun 4, 2018

mjmahone commented Jun 4, 2018

nyteshade commented Jun 4, 2018

Add support for Symbol.toStringTag #1297

Add support for Symbol.toStringTag #1297

Conversation

nyteshade commented Mar 23, 2018

facebook-github-bot commented Mar 23, 2018

nyteshade commented Mar 24, 2018

IvanGoncharov commented Mar 26, 2018

nyteshade commented Mar 26, 2018

IvanGoncharov commented Mar 27, 2018

leebyron left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nyteshade commented Mar 30, 2018

facebook-github-bot commented Apr 4, 2018

IvanGoncharov commented May 24, 2018 • edited Loading

nyteshade commented May 24, 2018

IvanGoncharov commented May 24, 2018

nyteshade commented May 25, 2018

IvanGoncharov commented May 25, 2018

nyteshade commented May 25, 2018 • edited Loading

IvanGoncharov May 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nyteshade commented May 29, 2018

IvanGoncharov commented May 29, 2018

nyteshade commented May 29, 2018

nyteshade commented May 31, 2018

IvanGoncharov commented Jun 4, 2018

mjmahone commented Jun 4, 2018

nyteshade commented Jun 4, 2018

IvanGoncharov commented May 24, 2018 •

edited

Loading

nyteshade commented May 25, 2018 •

edited

Loading

IvanGoncharov May 27, 2018 •

edited

Loading