Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY with MaybePromise #1164

Merged
merged 1 commit into from
Dec 19, 2017
Merged

DRY with MaybePromise #1164

merged 1 commit into from
Dec 19, 2017

Conversation

mohawk2
Copy link
Contributor

@mohawk2 mohawk2 commented Dec 17, 2017

MaybePromise<T> type, to avoid constantly declaring Promise<some stuff> | some stuff. Most visible in execute.js but also in a few other places.

@leebyron leebyron merged commit 63a9488 into graphql:master Dec 19, 2017
@leebyron
Copy link
Contributor

I'm into it.

@mohawk2 mohawk2 deleted the maybepromise branch December 19, 2017 01:08
@snyk-bot snyk-bot mentioned this pull request May 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohawk2 @leebyron @facebook-github-bot