Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use validation helper to check if GraphQLSchema instance #1134

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/utilities/extendSchema.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import keyMap from '../jsutils/keyMap';
import { ASTDefinitionBuilder } from './buildASTSchema';
import { GraphQLError } from '../error/GraphQLError';
import { GraphQLSchema } from '../type/schema';
import { assertValidSchema } from '../type/validate';

import {
GraphQLList,
Expand Down Expand Up @@ -72,10 +73,7 @@ export function extendSchema(
documentAST: DocumentNode,
options?: Options,
): GraphQLSchema {
invariant(
schema instanceof GraphQLSchema,
'Must provide valid GraphQLSchema',
);
assertValidSchema(schema);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good call to check this here - but I'm not sure we want to assert the whole schema is valid before extending it, we want to preserve the use case where you can extend an incomplete schema to get to a complete one.

I have an idea to extract just this check out, one sec while I test it out


invariant(
documentAST && documentAST.kind === Kind.DOCUMENT,
Expand Down