Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Potentially Breaking) Allow serializing scalars as null. #1104

Merged
merged 1 commit into from
Dec 1, 2017

Conversation

leebyron
Copy link
Contributor

@leebyron leebyron commented Dec 1, 2017

This changes the check for null/undefined to a check for undefined to determine if scalar serialization was successful or not, allowing null to be returned from serialize() without indicating error.

This is potentially breaking for any existing custom scalar which returned null from serialize() to indicate failure. To account for this change, it should either throw an error or return undefined.

Fixes #1057
Closes #1066

This changes the check for null/undefined to a check for undefined to determine if scalar serialization was successful or not, allowing `null` to be returned from serialize() without indicating error.

This is potentially breaking for any existing custom scalar which returned `null` from `serialize()` to indicate failure. To account for this change, it should either throw an error or return `undefined`.

Fixes #1057
Closes #1066
@leebyron leebyron merged commit 2218369 into master Dec 1, 2017
@leebyron leebyron deleted the serialize-nulls branch December 1, 2017 23:26
@kerryChen95
Copy link

Hope for publishing this to npm as soon as possible 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants