(Potentially Breaking) Allow serializing scalars as null. #1104
+13
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the check for null/undefined to a check for undefined to determine if scalar serialization was successful or not, allowing
null
to be returned from serialize() without indicating error.This is potentially breaking for any existing custom scalar which returned
null
fromserialize()
to indicate failure. To account for this change, it should either throw an error or returnundefined
.Fixes #1057
Closes #1066