Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if process is defined (for usage in the browser) #1058

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Check if process is defined (for usage in the browser) #1058

merged 1 commit into from
Oct 13, 2017

Conversation

aortbals
Copy link
Contributor

@aortbals aortbals commented Oct 6, 2017

When running this library in the browser, Node.js's process global is not necessarily defined. Usage in the browser is great for certain use cases. This adds a simple check that process is defined before using it in assertValidName.js

@wincent
Copy link
Contributor

wincent commented Oct 13, 2017

Thanks @aortbals. Seems quite reasonable.

@wincent wincent merged commit 6e7d51d into graphql:master Oct 13, 2017
@milosdanilov milosdanilov mentioned this pull request Feb 21, 2018
Closed
@justinfagnani justinfagnani mentioned this pull request Oct 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aortbals @wincent @facebook-github-bot