Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Babel 7 #1266

Closed
leebyron opened this issue Mar 2, 2018 · 4 comments
Closed

Migrate to Babel 7 #1266

leebyron opened this issue Mar 2, 2018 · 4 comments

Comments

@leebyron
Copy link
Contributor

leebyron commented Mar 2, 2018

Following React's move to Babel v7, GraphQL.js should do the same. The babel config for this project is not that complex, so hopefully this is an easy transition.

@leebyron
Copy link
Contributor Author

leebyron commented Mar 2, 2018

Something to consider is Babel v7 may not build correctly on Travis CI's Node v4 subjob. Technically we don't care about Babel builds on Node v4, but we do want the npm distributed bundle to be Node v4 safe - at least through the LTS window (end of April)

We could either:

  • drop the CI job early and keep our fingers crossed and eyes open,
  • wait to do this migration until May
  • write a slightly complex CI job that uses a different version of node to run the build than run the tests on the output

@AaronCCWong
Copy link
Contributor

AaronCCWong commented May 14, 2018

Is this waiting on babel v7 to come out of beta? If not, I'd like to take a stab at it.

@IvanGoncharov
Copy link
Member

Implemented in #1350 by @AaronCCWong 👍

@leebyron
Copy link
Contributor Author

Great work, @AaronCCWong!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants