Allow for nullish values when defining enums

Fixes #832
graphql · Apr 29, 2017 · b013e73 · b013e73
1 parent d7fe661
commit b013e73
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/src/type/__tests__/definition-test.js b/src/type/__tests__/definition-test.js
@@ -184,6 +184,33 @@ describe('Type System: Example', () => {
     });
   });
 
+  it('defines an enum type with a value of `null` and `undefined`', () => {
+    const EnumTypeWithNullishValue = new GraphQLEnumType({
+      name: 'EnumWithNullishValue',
+      values: {
+        NULL: { value: null },
+        UNDEFINED: { value: undefined },
+      }
+    });
+
+    expect(EnumTypeWithNullishValue.getValues()).to.deep.equal([
+      {
+        name: 'NULL',
+        description: undefined,
+        isDeprecated: false,
+        deprecationReason: undefined,
+        value: null,
+      },
+      {
+        name: 'UNDEFINED',
+        description: undefined,
+        isDeprecated: false,
+        deprecationReason: undefined,
+        value: undefined,
+      },
+    ]);
+  });
+
   it('defines an object type with deprecated field', () => {
     const TypeWithDeprecatedField = new GraphQLObjectType({
       name: 'foo',

diff --git a/src/type/definition.js b/src/type/definition.js
@@ -9,7 +9,6 @@
  */
 
 import invariant from '../jsutils/invariant';
-import isNullish from '../jsutils/isNullish';
 import { ENUM } from '../language/kinds';
 import { assertValidName } from '../utilities/assertValidName';
 import type {
@@ -984,7 +983,7 @@ function defineEnumValues(
       description: value.description,
       isDeprecated: Boolean(value.deprecationReason),
       deprecationReason: value.deprecationReason,
-      value: isNullish(value.value) ? valueName : value.value,
+      value: value.hasOwnProperty('value') ? value.value : valueName,
     };
   });
 }