Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: render query history panel only when it's toggled #1821

Merged
merged 5 commits into from
Apr 4, 2021

Conversation

harshithpabbati
Copy link
Contributor

Rendering the history panel only when it's toggled instead of using CSS to hide it.

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2021

🦋 Changeset detected

Latest commit: 6dd3198

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphiql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@acao
Copy link
Member

acao commented Apr 1, 2021

ah! i think there's a bug in the new github actions workflow config where it doesn't work on PR create. if you push another commit it should test and deploy. I'll need to go fix that!

@acao
Copy link
Member

acao commented Apr 1, 2021

hmm! still no dice! strange. but the PR looks great, thank you!

@harshithpabbati harshithpabbati force-pushed the query-history-panel branch 2 times, most recently from c957c7b to 4c94685 Compare April 1, 2021 18:42
@acao
Copy link
Member

acao commented Apr 1, 2021

this is a good move, thanks @harshithpabbati !

@harshithpabbati
Copy link
Contributor Author

hmm, test cases failed because the history panel is no more available in dom.

@acao
Copy link
Member

acao commented Apr 1, 2021

it should be once it's toggled open!

@harshithpabbati
Copy link
Contributor Author

it should be once it's toggled open!

yup, did that!

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #1821 (6dd3198) into main (3e2c9c8) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1821      +/-   ##
==========================================
+ Coverage   65.66%   65.83%   +0.16%     
==========================================
  Files          85       85              
  Lines        5115     5108       -7     
  Branches     1635     1633       -2     
==========================================
+ Hits         3359     3363       +4     
+ Misses       1752     1741      -11     
  Partials        4        4              
Impacted Files Coverage Δ
packages/graphiql/src/components/GraphiQL.tsx 58.09% <100.00%> (+0.58%) ⬆️
packages/graphiql-toolkit/src/createFetcher.ts
packages/graphiql-toolkit/src/lib.ts
...ackages/graphiql-toolkit/src/create-fetcher/lib.ts 59.57% <0.00%> (ø)
...aphiql-toolkit/src/create-fetcher/createFetcher.ts 60.71% <0.00%> (ø)
packages/graphiql/src/components/ToolbarButton.tsx 92.85% <0.00%> (+21.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e2c9c8...6dd3198. Read the comment docs.

@acao
Copy link
Member

acao commented Apr 3, 2021

thank you again @harshithpabbati !

@acao
Copy link
Member

acao commented Apr 3, 2021

@harshithpabbati just need to fix the formatting bug, may have been introduced by changesets. thus why its easier when you run yarn changeset locally yourself!

@harshithpabbati
Copy link
Contributor Author

@acao, fixed it!

@acao acao merged commit 9f8c78c into graphql:main Apr 4, 2021
@github-actions github-actions bot mentioned this pull request Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants