-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: peer resolutions, limit example workspaces #1816
Conversation
🦋 Changeset detectedLatest commit: f53945f The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## main #1816 +/- ##
=======================================
Coverage 65.66% 65.66%
=======================================
Files 85 85
Lines 5115 5115
Branches 1635 1635
=======================================
Hits 3359 3359
Misses 1752 1752
Partials 4 4 Continue to review full report at Codecov.
|
297fba5
to
5241fe5
Compare
Welcome back 🙂 |
thanks @imolorhe !! excited to be back! I'll be contributing more some evenings this week and weekend. I really really appreciate your co-maintainership during my hiatus! |
adding "resolutions": {
"graphql-language-service-parser": "1.9.0",
"graphql-language-service-interface": "2.8.2"
}
to |
this provides more targeted peer resolutions, based on known compatibility.
[email protected]
is when built-ingraphql
types are required. the last14.4.x
release before that also added a new method that we use.this also limits the scope of the workspaces to monaco, so that both start commands work, and the yarn lockfile can shrink in size and duplicate resolution complexity because of create-react-app/etc in other examples
prompts for review:
|| experimental-defer-stream
?manypkg
that has afix
command that will normalize the dependency versions of all the workspaces, preventing issues with clashing versions. it will resolve to the highest version, and has a rule to automatically add the peer dependencies as a devDependency. we can include another commit to this PR with this fix, which would require some type fixes in language server because of babel versions infindGraphQLTags
. this could also be another PR, but naturally makes sense as the next step after this PR