Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: move incremental client from fmg to meros #1774

Merged
merged 9 commits into from
Jan 29, 2021
Merged

improvement: move incremental client from fmg to meros #1774

merged 9 commits into from
Jan 29, 2021

Conversation

maraisr
Copy link
Contributor

@maraisr maraisr commented Jan 26, 2021

With this PR I aim to replace fmg with meros, for better isomorphic nature and ease of use.


relates: #1770

@acao
Copy link
Member

acao commented Jan 26, 2021

ah, yeah you have to run yarn build at the root first! it will probably pass in CI, no worries

@acao
Copy link
Member

acao commented Jan 26, 2021

these test failures are strange! just missing arguments from some assertions

@acao
Copy link
Member

acao commented Jan 26, 2021

ah, still the unrelated test failures that shouldn't be happening. ill take a look!

@acao
Copy link
Member

acao commented Jan 26, 2021

ah, @maraisr you need to update the tests because you change how createMultipartFetcher is invoked! they are related as it turns out. you just need to add fetch to a few assertions

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #1774 (ae9137f) into feat/build-fetcher-util (26feeeb) will decrease coverage by 0.03%.
The diff coverage is 16.00%.

Impacted file tree graph

@@                     Coverage Diff                     @@
##           feat/build-fetcher-util    #1774      +/-   ##
===========================================================
- Coverage                    65.72%   65.69%   -0.04%     
===========================================================
  Files                           85       85              
  Lines                         5083     5087       +4     
  Branches                      1610     1605       -5     
===========================================================
+ Hits                          3341     3342       +1     
- Misses                        1715     1718       +3     
  Partials                        27       27              
Impacted Files Coverage Δ
packages/graphiql-create-fetcher/src/lib.ts 55.10% <0.00%> (-3.60%) ⬇️
packages/graphiql/src/components/GraphiQL.tsx 57.80% <20.00%> (+0.06%) ⬆️
...kages/graphiql-create-fetcher/src/createFetcher.ts 65.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26feeeb...ae9137f. Read the comment docs.

@acao acao changed the title Move incremental client from fmg to meros improvement: move incremental client from fmg to meros Jan 29, 2021
@acao acao merged commit 3292e85 into graphql:feat/build-fetcher-util Jan 29, 2021
@maraisr maraisr deleted the to-meros branch January 29, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants