-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monaco Mode - Phase 1 #1421
Closed
Closed
Monaco Mode - Phase 1 #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
a0a0f46
to
e0291d3
Compare
aa536aa
to
38a1cf1
Compare
Codecov Report
@@ Coverage Diff @@
## master #1421 +/- ##
==========================================
- Coverage 58.98% 57.87% -1.11%
==========================================
Files 60 63 +3
Lines 3023 3091 +68
Branches 806 819 +13
==========================================
+ Hits 1783 1789 +6
- Misses 1194 1256 +62
Partials 46 46
Continue to review full report at Codecov.
|
a64fed1
to
3ec78fb
Compare
b1b3544
to
d1bb9d1
Compare
7 tasks
d1bb9d1
to
0d0f6b5
Compare
0d0f6b5
to
de3f8ce
Compare
closed for #1459 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rfc
Request for Comment
work-in-progress
not ready to merge yet, PR is available for demonstration/review purposes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the first phase, we will only support completion and maybe diagnostics. Summarized more completely in #1445
Note: I will be pulling all the LSP changes out of this PR and creating seperate PRs to introduce those, so that this PR will soon be ~20 new files, a few changes and thats it, ideally.
Everything that isn't complete is partially underway. The only issue now is that monaco can't find the AMD id of our custom language worker.
Outcomes
packages/monaco-graphql
andexamples/monaco-webpack
Todo
Scoped to only completion for now. Other features will be iterative
How to Develop/Test
yarn --force
yarn tsc --watch
(one time)yarn build-ts
examples/monaco-graphql
:yarn start