-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export more functions #1264
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -250,6 +250,16 @@ export type ContextToken = { | |
style: string; | ||
}; | ||
|
||
export type ContextTokenForCodeMirror = { | ||
start: number; | ||
end: number; | ||
string: string; | ||
type: string | null; | ||
state: State; | ||
}; | ||
|
||
export type ContextTokenUnion = ContextToken | ContextTokenForCodeMirror; | ||
|
||
export type AllTypeInfo = { | ||
type: Maybe<GraphQLType>; | ||
parentType: Maybe<GraphQLType>; | ||
|
@@ -282,11 +292,24 @@ export type ObjectTypeInfo = { | |
|
||
export type Diagnostic = DiagnosticType; | ||
|
||
export type CompletionItemBase = { | ||
label: string; | ||
isDeprecated?: boolean; | ||
}; | ||
|
||
export type CompletionItem = CompletionItemType & { | ||
isDeprecated?: boolean; | ||
deprecationReason?: Maybe<string>; | ||
}; | ||
|
||
export type CompletionItemForCodeMirror = { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what is diffferent about this type? do you just need to make it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In a successive PR, |
||
label: string; | ||
type?: GraphQLType; | ||
documentation: string | null | undefined; | ||
isDeprecated?: boolean; | ||
deprecationReason: string | null | undefined; | ||
}; | ||
|
||
// Below are basically a copy-paste from Nuclide rpc types for definitions. | ||
|
||
// Definitions/hyperlink | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ContextToken
is only used by Codemirror, so lets combine this into one typeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't
ContextToken
used insidegraphql-language-service-interface
even if you do with vscode?graphiql/packages/graphql-language-service-interface/src/getAutocompleteSuggestions.ts
Line 394 in 917c393