This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
Pass through the logFn option to execute #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Going to close this out as it is quite stale now. We should revisit this once the details in graphql/graphql-js#402 have been hammered out. Thanks for the PR @Slava! |
|
okie :( Hope we can find a better more elegant solution to this. |
Yep, I think the best way to do that is to push on with the discussion in graphql/graphql-js#402 — specifically:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is accommodating graphql/graphql-js#402
Once that PR is merged, this will one will be a logical pass through.