Field error refactor #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhallin Is there any particular reason you are not merging this in? |
|
Probably waiting for feedback. I'll try to carve out some time to go over all MRs tomorrow. |
|
Yeah, I personally don't have a use case for sending extra data with errors so I wanted some input from someone else if this looks reasonable and solves their problem. |
|
@mhallin I finally looked over the PR and it looks good to me. Should cover the use case of detailed errors well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial attempt at solving #69 and #40. It pretty much matches what I wrote here: #40 (comment).
To ease construction of custom error objects, I built a small macro to construct
Valueinstances from JSON syntax. This might be a bit out of place, in which case it can be removed from the PR. I also don't think it's going to be used for other purposes, but whatever :)This obviously breaks all users of
.to_field_errbecause of the renaming and places where you returnErr("string literal".to_owned())from a field, but all instances of e.g.let txn = executor.context().db.transaction()?should continue to work.