Clean up clippy warnings remove try! #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atul9
force-pushed
the
clean_clippy_remove_try
branch
2 times, most recently
from
6fb8fba
to
a7d843e
Compare
Atul9
changed the title
Atul9
force-pushed
the
clean_clippy_remove_try
branch
2 times, most recently
from
eb110fc
to
438d56a
Compare
Atul9
changed the title
|
@Atul9 do you need help with figuring out the build failures? |
|
@theduke Yes, I need help with figuring out the build failures. I had mentioned this on the issue #131 (comment) |
It doesn't appear that `:tt` accepts the `stringify!()`-ed value in this position. The :tt is only later used as an `:expr` to produce the name for metadata purposes. Converting this position to be an `:expr` allows the `stringify!()`-ed value and accepts all current uses of the `graphql_scalar!()` macro in this repository.
The conversions in this changeset cannot use the `From<T>` trait implementation because the conversion is lossy, either because they involve converting a signed value to an unsigned value (`i32`⇒`u64`) or because the convert from a larger data type to a smaller one (`u64`⇒`i32`). In this case, the `as` type cast is necessary to perform a bitwise conversion. This coercion can cause negative values to become very large unsigned values. This is intentional on line 90.
The `E::custom()` function requires a value of any type that implements `fmt::Display`, so a plain `&str` works just fine here.
theduke
force-pushed
the
clean_clippy_remove_try
branch
from
3685a21
to
5fad1c4
Compare
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
+ Coverage 90.24% 90.39% +0.14%
==========================================
Files 95 95
Lines 16429 16913 +484
==========================================
+ Hits 14827 15289 +462
- Misses 1602 1624 +22
Continue to review full report at Codecov.
|
|
@Atul9 @neoeinstein thanks a bunch to you both, that was quite a bite of work. |
|
@neoeinstein also thanks for the detailed commit messages. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #131