Abstract (start, end) from Spanning struct into new struct Span #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audunhalland
force-pushed
the
spanning-span
branch
from
d814053 to
c16ad76
Compare
audunhalland
force-pushed
the
spanning-span
branch
from
c16ad76 to
70cd07b
Compare
tyranron
added
enhancement
…ng-span # Conflicts: # juniper/CHANGELOG.md # juniper/src/parser/document.rs # juniper/src/parser/parser.rs # juniper/src/parser/utils.rs
tyranron
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
@audunhalland thanks for the effort!
I've bikeshedded your solution a bit, around accepting/returning references for Copy type in new APIs, and readability/understandability where Spanning::start()/Spanning::end() methods are used.
audunhalland
commented
Nov 9, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to treat the source region (the Span) separately from the spanned item in Spanning.