Axum integration #1088

btielen · 2022-07-24T16:46:33Z

This PR provides an integration for Axum including subscriptions (fixes #986)

including http tests run by juniper::http::tests::run_http_test_suite
including websocket tests run by juniper::http::tests::run_ws_test_suite

Get started

Run cargo run -p juniper_axum --example simple from the root directory, and navigate to 127.0.0.1:3000 in your browser.

Other changes

Minor changes were made in other libraries

Added an Error for the implementation of Sink for juniper_graphql_ws::Connection, so the code doesn't panic.
Added an extra test in juniper::http::tests::run_ws_test_suite to test POST requests with variables

Discussion

Documentation probably needs some polishing
juniper::http::GraphQLRequest now has a property variables with type Option<InputValue<S>>, I think (but not sure) things would be easier if this has the type Variables<S>
I didn't test requests with an operation_name defined

Any help polishing this PR is appreciated :)

btielen · 2022-07-24T17:26:06Z

In case this PR will get merged, it would be nice to update the projects documentation and book to point out an integration for Axum exists.

btielen

Some notes

btielen · 2022-07-24T17:40:30Z

juniper_axum/Cargo.toml

+
+[dependencies]
+axum = { version = "0.5.11", features = ["ws"]}
+juniper = { path = "../juniper" }


Is a version required?

@btielen in the same way as other integrations have. The version bump is automated with cargo-release. See release.toml files for examples.

LegNeato

Wow, this is an AMAZING PR 🥳 . Thank you for the change, adding docs, and adding tests! I especially like that you improved the ws stuff while you where here.

Some small nits but it looks solid otherwise.

LegNeato · 2022-07-28T23:06:19Z

juniper_axum/CHANGELOG.md

+
+## master
+
+### BC Breaks


Just remove this section and put something like:

Initial release

LegNeato · 2022-07-28T23:06:39Z

juniper_axum/CHANGELOG.md

+
+## Previous releases
+
+See [old CHANGELOG](/../../blob/juniper_warp-v0.0.0/juniper_axum/CHANGELOG.md).


This mentions warp and should be deleted.

LegNeato · 2022-07-28T23:07:24Z

juniper_axum/Cargo.toml

+
+[dependencies]
+axum = { version = "0.5.11", features = ["ws"]}
+juniper = { path = "../juniper" }


As mentioned in the PR comments already, this should have a version and wired up to the release machinery.

LegNeato · 2022-07-28T23:07:30Z

juniper_axum/Cargo.toml

+juniper = { path = "../juniper" }
+serde = "1.0"
+serde_json = "1.0"
+juniper_graphql_ws = { path="../juniper_graphql_ws" }


juniper_axum/README.md

LegNeato · 2022-07-28T23:08:52Z

juniper_axum/README.md

+[Juniper Book]: https://graphql-rust.github.io
+[Rust]: https://www.rust-lang.org
+
+[1]: https://github.com/graphql-rust/juniper/blob/master/juniper_warp/examples/warp_server.rs


juniper_warp/src/lib.rs

ilslv · 2022-08-03T12:02:28Z

juniper_axum/examples/simple.rs


    let context = Context;

    let app = Router::new()
-        .route("/", get(|| playground("/graphql", Some("/subscriptions"))))


@btielen Great job, thanks! I've made some insignificant changes though. Most notably simplifying the usage of the playground, now it feels to me a lot more axumy.

ilslv · 2022-08-03T12:03:26Z

juniper_axum/examples/simple.rs

@@ -72,20 +74,20 @@ async fn main() {
 }

 pub async fn juniper_subscriptions(
-    Extension(schema): Extension<Arc<AppSchema>>,


Also I've removed a need to wrap all Schemes into Arcs.

btielen · 2022-08-04T07:57:29Z

Thanks for the feedback, I will take a look at it tomorrow.

harksin · 2022-10-16T14:19:50Z

👋 Incredible work 🤩 , Is there any plan to merge & release it ?

urothis · 2023-02-16T19:15:42Z

Any blockers on merging this?

Cugatay · 2023-03-18T23:53:04Z

Hey, are you going to push Axum integration? I loved Axum when I tried it, and I want to use something I already know when using GraphQL

LegNeato · 2023-04-05T00:16:54Z

There are still outstanding review comments here...

frederikhors · 2023-05-18T15:55:00Z

@btielen are you able to fix those changes so to merge this?

tyranron · 2023-10-27T16:28:57Z

I plan to finish it in next few weeks.

# Conflicts: # juniper/src/http/mod.rs # juniper_actix/src/lib.rs # juniper_graphql_ws/src/lib.rs # juniper_warp/src/lib.rs

…ql-ws` protocols

tyranron · 2023-11-08T15:42:39Z

Progress

Parametrized extractor::JuniperRequest with ScalarValue.
Reworked legacy graphql-ws GraphQL over WebSocket Protocol implementation.
Fixed doc tests.
Added new graphql-transport-ws GraphQL over WebSocket Protocol implementation.
Implemented auto-selection between new graphql-transport-ws and legacy graphql-ws GraphQL over WebSocket Protocol implementations.
Add ready-to-go default graphql, subscriptions::ws, subscriptions::graphql_ws and subscriptions::graphql_trasnport_ws handlers.
Polished API docs.

tyranron · 2023-11-08T18:51:42Z

@LegNeato I'm going to merge this in next few days. Take a final look, if you would like. All the stuff is ready, only minor CI issues are left to be resolved.

btielen added 5 commits July 24, 2022 18:25

Add Error to Connection Stream

bc7f4a8

Add post_with_variables test

11ecc25

Decouple test and implementation

2932e6e

Add juniper_axum

719eb97

Clippy and format

183302c

btielen changed the title ~~Axum~~ Axum integration Jul 24, 2022

btielen commented Jul 24, 2022

View reviewed changes

tyranron assigned btielen Jul 25, 2022

tyranron added the k::integration Related to integration with third-party libraries or systems label Jul 25, 2022

tyranron requested a review from ilslv July 25, 2022 07:54

tyranron added this to the 0.16.0 milestone Jul 25, 2022

LegNeato requested changes Jul 28, 2022

View reviewed changes

ilslv added 2 commits August 3, 2022 10:46

Merge branch 'master' into axum

f9326e5

Corrections

59ab64a

ilslv approved these changes Aug 3, 2022

View reviewed changes

tyranron modified the milestones: 0.16.0, 0.17.0 Oct 17, 2022

LegNeato added 2 commits August 28, 2023 17:22

Update juniper_axum/README.md

7414b4c

Update juniper_warp/src/lib.rs

e1a1104

tyranron modified the milestones: 0.17.0, 0.16.0 Oct 27, 2023

Merge branch 'master' into axum

fbef4c0

# Conflicts: # juniper/src/http/mod.rs # juniper_actix/src/lib.rs # juniper_graphql_ws/src/lib.rs # juniper_warp/src/lib.rs

tyranron added the lib::axum Related to `axum` crate integration label Nov 7, 2023

tyranron added 10 commits November 8, 2023 12:53

Parametrize with ScalarValue

baea7e6

Fix extract unit tests

8961631

Rework graphql-ws subscriptions

2a819fd

Fix doc tests

ac97a3a

Add graphql-transport-ws impl

4600686

Impl auto-selection between new graphql-transport-ws and old `graph…

3b3e7e3

…ql-ws` protocols

Add ready-to-go graphql handler

4d89d51

Add ready-to-go ws, graphql_ws and graphql_transport_ws handlers

ccac700

Fix docs

fa73e0b

Add release.toml [skip ci]

5491556

tyranron added 5 commits November 8, 2023 17:48

Update workspace

90bcc3c

Rework simple example

cac125f

Rework strawars example as custom

afa9521

Reworking integration tests, vol.1

e2561c7

Reworking integration tests, vol.2

8ba8de5

tyranron marked this pull request as ready for review November 8, 2023 18:15

tyranron added 2 commits November 8, 2023 20:31

Fill-up CHANGELOG

c44f5cd

Fix tests

c9cf94e

tyranron requested a review from LegNeato November 8, 2023 18:51

Try fix MSRV

bb6dcaa

tyranron approved these changes Nov 8, 2023

View reviewed changes

tyranron linked an issue Nov 9, 2023 that may be closed by this pull request

Example to integrate with Axum #1184

Closed

tyranron merged commit 7617102 into graphql-rust:master Nov 9, 2023
182 checks passed

tyranron added k::documentation Related to project documentation k::api Related to API (application interface) k::example Related to usage examples feature New feature or request labels Nov 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Axum integration #1088

Axum integration #1088

btielen commented Jul 24, 2022

btielen commented Jul 24, 2022

btielen left a comment

btielen Jul 24, 2022

tyranron Jul 25, 2022

LegNeato left a comment •

edited

Loading

LegNeato Jul 28, 2022

LegNeato Jul 28, 2022

LegNeato Jul 28, 2022

LegNeato Jul 28, 2022

LegNeato Jul 28, 2022

ilslv Aug 3, 2022

ilslv Aug 3, 2022

btielen commented Aug 4, 2022

harksin commented Oct 16, 2022

urothis commented Feb 16, 2023

Cugatay commented Mar 18, 2023

LegNeato commented Apr 5, 2023

frederikhors commented May 18, 2023

tyranron commented Oct 27, 2023

tyranron commented Nov 8, 2023

tyranron commented Nov 8, 2023


		## Previous releases

		See [old CHANGELOG](/../../blob/juniper_warp-v0.0.0/juniper_axum/CHANGELOG.md).

Axum integration #1088

Axum integration #1088

Conversation

btielen commented Jul 24, 2022

Get started

Other changes

Discussion

btielen commented Jul 24, 2022

btielen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LegNeato left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

btielen commented Aug 4, 2022

harksin commented Oct 16, 2022

urothis commented Feb 16, 2023

Cugatay commented Mar 18, 2023

LegNeato commented Apr 5, 2023

frederikhors commented May 18, 2023

tyranron commented Oct 27, 2023

tyranron commented Nov 8, 2023

Progress

tyranron commented Nov 8, 2023

LegNeato left a comment •

edited

Loading