Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for @defer directive #213

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bholemt
Copy link

@bholemt bholemt commented Nov 6, 2018

Implementation for @defer directive in graphene. Have tested it with Apollo Client alpha versions -

"apollo-boost": "0.2.0-alpha.14",
"graphql": "14.0.2",
"react-apollo": "2.2.0-alpha.3",
"react-scripts": "1.1.5"

Will also need corresponding changes in flask-graphql, sanic-graphql etc.

Existing test cases are working. However new test cases are not yet added.

@bholemt bholemt changed the title Deferred Support for @defer directive Nov 6, 2018
@bholemt
Copy link
Author

bholemt commented Nov 6, 2018

One test case failing on base master branch itself.

@janbaykara
Copy link

Any update on this one?

@Cito
Copy link
Member

Cito commented Sep 25, 2019

GraphQL-core is a port of GraphQL.js. As soon as @defer is part of the standard and included in GraphQL.js, it will be ported to GraphQL-core as well. We don't want to add and mix in more features than GraphQL.js supports because then it will become incompatible and very difficult to stay in sync with GraphQL.js. See also graphql/graphql-spec#269

@flzozaya
Copy link

flzozaya commented Dec 1, 2020

Is there any update or progress on this, now that support for @defer and @stream directives are now part of GraphQL.js (as experimental branch)?
graphql/graphql-js#2319

@Cito
Copy link
Member

Cito commented Dec 1, 2020

@flzozaya This will be eventually included in GraphQL-Core 3, but not in GraphQL-Core 2 (the legacy branch).

@arjunlol
Copy link

@Cito would you know if defer support ended up being prioritized into GraphQL-Core 3?

@Cito
Copy link
Member

Cito commented Mar 16, 2022

@arjunlol This is still only in an experimental branch in GraphQL.js, so it's not yet in GraphQL-core 3. We are also working on another mechanism to defer execution, see PR 155.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants