Argument default value should be undefined

[wakemaster39]

resolves #1195

This stops null from being populated in the introspection query as mentioned in #1195. This also solves the problem of None being passed into the kwargs of a mutate call if no value was passed in by the end user.

[wakemaster39]

I am unsure which of the two options you want me to do to fix the unit tests.

1, set default values for the failing tests to be None.
2, remove the no longer passed in values from the assertion statements.

[DonQueso89]

I am unsure which of the two options you want me to do to fix the unit tests.

1, set default values for the failing tests to be None.
2, remove the no longer passed in values from the assertion statements.

thumbs up for this PR!

I would say remove the no longer passed in values from the assertion right? We're testing whether the value is absent if its not passed in

[zbyte64]

See the commit to fix the test.

[zbyte64]

I think this is causing the test to fail. It applies black formatting to the code an fails if the file changes. This is where it cites the changed file: https://travis-ci.org/github/graphql-python/graphene/jobs/753187127#L243

[wakemaster39]

Ok I finally got around to cleaning up the changes that moving to Undefined makes to the unit tests. This should be good to go now. Fixed the fact I forgot to run pre-commit along the way.

[zbyte64]

👍

[ramyak-mehra]

What's the updated on this one?

[lovetoburnswhen]

+1 this seems like a critical feature

[SteinRobert]

Does this PR need any more work? I'd be happy to help, otherwise I would really appreciate this to make it into the next release 😃

[frankchen211]

any update?

[SteinRobert]

@Cito @jkimbo you guys probably have a lot of work on your hands, thank you so much for caring about the project!
Just wanted to check in whether this change is something you consider accepting or if it needs any more work. I'd surely help making any more changes if needed.

[erikwrede]

Hey everyone,
sorry for the long wait; this fix is already merged:
19ebf08
It should be included in 3.1.0

Closing this.