Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: limit lint runs to master pushes and PRs #382

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Conversation

sabard
Copy link
Collaborator

@sabard sabard commented Feb 15, 2023

As tests were running twice per commit in PRs, so is linting. This change prevents that.

Shouldn't make a difference so long as the default branch is protected from merging without a PR and people are using pre-commit.

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 96.36% // Head: 96.39% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (d24153f) compared to base (d3a4320).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage   96.36%   96.39%   +0.03%     
==========================================
  Files           9        9              
  Lines         908      916       +8     
==========================================
+ Hits          875      883       +8     
  Misses         33       33              
Impacted Files Coverage Δ
graphene_sqlalchemy/converter.py 95.83% <0.00%> (+0.01%) ⬆️
graphene_sqlalchemy/utils.py 96.09% <0.00%> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erikwrede erikwrede merged commit ba0597f into master Feb 27, 2023
@sabard sabard deleted the fix-lint branch February 27, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants